Repository navigation
DotClockFramebuffer: define the bounce_rows range where the constructor can see it - #44
Merged
Merged
Conversation
…ructor can see it #42 defined DCFB_BOUNCE_ROWS_MAX/MIN inside the 'defined(ESP_PLATFORM) && SOC_LCD_RGB_SUPPORTED' block, but the constructor that checks bounce_rows= against them is outside it. The esp32 port compiles user C modules a second time in the executable's own target, without ESP_PLATFORM, and there the block is empty: every esp32 build that carries displayif fails with 'DCFB_BOUNCE_ROWS_MAX undeclared'. Found building ESP32_GENERIC_P4 for the micropython-pydevices reorg; the old board-dir build configures the file the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#42 defined
DCFB_BOUNCE_ROWS_MAX/_MINinside thedefined(ESP_PLATFORM) && SOC_LCD_RGB_SUPPORTEDblock, but the constructor that checksbounce_rows=against them sits outside it. The esp32 port compiles user C modules a second time in the executable's own target (micropython.elf), withoutESP_PLATFORM, and in that compile the block is empty. So an esp32 build that carries displayif fails with'DCFB_BOUNCE_ROWS_MAX' undeclared.Found building
ESP32_GENERIC_P4C6_WIFIfor the micropython-pydevices reorg. A CMake configure of the old way (the panel's own board dir) compilesmod_dotclockframebuffer.cin the executable withoutESP_PLATFORMtoo, so this isn't the new build's doing.The fix moves the two constants above the guard. Proved: the same P4 build, with this branch as its displayif, builds to a
firmware.bin(2.9 MB image). Nothing else changes.