Conversation
i18n(weekly-mr:app): Upgrade translations from crowdin (2d51304). for webapps See merge request web/clients!25193
Add support for system groups See merge request web/clients!25054
Extracting reused withTimeout to package/meet/utils See merge request web/clients!25060
Disable auto-complete on chat See merge request web/clients!25115
Scopes usernames with bdi See merge request web/clients!25117
fix(account): remove access check in categories settings See merge request web/clients!25198
Do not scroll element in view when changing page See merge request web/clients!25197
Rework byoe access check See merge request web/clients!25202
[REALTIME-240] Homepage SDK - folder events See merge request web/clients!25110
i18n(weekly-mr:app): Upgrade translations from crowdin (53310fd). for webapps See merge request web/clients!25210
Fix upsell path See merge request web/clients!25217
Sheets: Fix issue with settings dialog menu item See merge request web/clients!25218
edvincandon
reviewed
Jun 24, 2026
| /** Only arm the field action-trap when the anchor field is the active element — i.e. the | ||
| * focus-recovery scenario. The shortcut flow opens the dropdown without focusing the field, | ||
| * so arming it there would needlessly suppress the field's normal autofocus dropdown. */ | ||
| if (anchor.current?.type === 'field' && isActiveElement(anchor.current.field.element)) { |
Contributor
There was a problem hiding this comment.
For your use-case : could we rather drill a boolean flag down onWillFocus & onFocusRequest rather than relying on an active element check here ? The reason being : by-passing focus-traps is time-sensitive and the document.activeElement may be stale when onWillFocus triggers from an actual dropdown initiated focus request (but not through your new exposed handle).
D-Bao
reviewed
Jun 24, 2026
Comment on lines
+380
to
+400
| const onAutofillTrigger: FrameMessageHandler<WorkerMessageType.AUTOFILL_TRIGGER> = withContext(async (ctx) => { | ||
| const dropdown = ctx?.service.inline.dropdown; | ||
| const fields = ctx?.service.formManager.getFields(); | ||
| const loginField = fields?.find((field) => field.action?.type === DropdownAction.AUTOFILL_LOGIN); | ||
|
|
||
| if (!dropdown || !loginField) return; | ||
|
|
||
| dropdown.toggle({ | ||
| type: 'field', | ||
| action: DropdownAction.AUTOFILL_LOGIN, | ||
| autofocused: false, | ||
| autofilled: loginField.autofilled !== null, | ||
| field: loginField, | ||
| }); | ||
|
|
||
| /** Keyboard-only flow: once the dropdown is visible, move keyboard focus into it | ||
| * so the user can navigate the login suggestions with the arrow keys and select | ||
| * one with Enter — without touching the mouse. Unlike the focus-on-field flow, | ||
| * the shortcut opens the dropdown with `autofocused: false`, so nothing has moved | ||
| * focus into the iframe yet. */ | ||
| await waitUntil(() => dropdown.getState().then(({ visible }) => visible), 25, DROPDOWN_AUTOFOCUS_TIMEOUT) |
Contributor
There was a problem hiding this comment.
There is a small type error when running yarn check-types inside applications/pass-extension, this shouldn't be async:
Suggested change
| const onAutofillTrigger: FrameMessageHandler<WorkerMessageType.AUTOFILL_TRIGGER> = withContext(async (ctx) => { | |
| const dropdown = ctx?.service.inline.dropdown; | |
| const fields = ctx?.service.formManager.getFields(); | |
| const loginField = fields?.find((field) => field.action?.type === DropdownAction.AUTOFILL_LOGIN); | |
| if (!dropdown || !loginField) return; | |
| dropdown.toggle({ | |
| type: 'field', | |
| action: DropdownAction.AUTOFILL_LOGIN, | |
| autofocused: false, | |
| autofilled: loginField.autofilled !== null, | |
| field: loginField, | |
| }); | |
| /** Keyboard-only flow: once the dropdown is visible, move keyboard focus into it | |
| * so the user can navigate the login suggestions with the arrow keys and select | |
| * one with Enter — without touching the mouse. Unlike the focus-on-field flow, | |
| * the shortcut opens the dropdown with `autofocused: false`, so nothing has moved | |
| * focus into the iframe yet. */ | |
| await waitUntil(() => dropdown.getState().then(({ visible }) => visible), 25, DROPDOWN_AUTOFOCUS_TIMEOUT) | |
| const onAutofillTrigger: FrameMessageHandler<WorkerMessageType.AUTOFILL_TRIGGER> = withContext((ctx) => { | |
| const dropdown = ctx?.service.inline.dropdown; | |
| const fields = ctx?.service.formManager.getFields(); | |
| const loginField = fields?.find((field) => field.action?.type === DropdownAction.AUTOFILL_LOGIN); | |
| if (!dropdown || !loginField) return; | |
| dropdown.toggle({ | |
| type: 'field', | |
| action: DropdownAction.AUTOFILL_LOGIN, | |
| autofocused: false, | |
| autofilled: loginField.autofilled !== null, | |
| field: loginField, | |
| }); | |
| /** Keyboard-only flow: once the dropdown is visible, move keyboard focus into it | |
| * so the user can navigate the login suggestions with the arrow keys and select | |
| * one with Enter — without touching the mouse. Unlike the focus-on-field flow, | |
| * the shortcut opens the dropdown with `autofocused: false`, so nothing has moved | |
| * focus into the iframe yet. */ | |
| void waitUntil(() => dropdown.getState().then(({ visible }) => visible), 25, DROPDOWN_AUTOFOCUS_TIMEOUT) |
Note that my suggestion may be changed if you implement #481 (comment)
mmso
force-pushed
the
main
branch
9 times, most recently
from
July 31, 2026 08:17
6e496e5 to
bfa5069
Compare
mmso
force-pushed
the
main
branch
4 times, most recently
from
August 12, 2026 08:17
d9d8f8f to
95ce65c
Compare
|
Please get this feature implemented! It has been a request for YEARS. |
mmso
force-pushed
the
main
branch
9 times, most recently
from
September 11, 2026 16:16
5eb5e79 to
28d81d1
Compare
mmso
force-pushed
the
main
branch
5 times, most recently
from
September 16, 2026 16:17
40a6c9b to
079f4b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a keyboard shortcut to trigger autofill in the Proton Pass browser extension, as discussed and approved in #453.
autofillcommand in Chrome and Firefox manifests withCtrl+Shift+Uas the default shortcutAUTOFILL_TRIGGERmessage to the active tab's content scriptCloses #453
Changes
manifest-chrome.json"autofill"command entrymanifest-firefox.json"autofill"command entrysrc/types/messages.tsAUTOFILL_TRIGGERtoWorkerMessageTypeenumsrc/lib/extension/commands.ts"autofill"commandsrc/lib/extension/commands.spec.tssrc/app/content/services/autofill/autofill.service.tsAUTOFILL_TRIGGERhandler usingwithContextpatternHow it works
Ctrl+Shift+Ubrowser.commands.onCommandfires in the background scriptAUTOFILL_TRIGGERviabrowser.tabs.sendMessageFrameMessageBrokerreceives the messageDropdownAction.AUTOFILL_LOGINviaformManager.getFields()inline.dropdown.toggle()If no login field is detected on the page, the shortcut is a no-op.
Design decisions
Default shortcut
Ctrl+Shift+U: Chosen to avoid conflicts with existing commands (Ctrl+Shift+Xfor popup,Ctrl+Shift+Lfor larger window). The industry standard for autofill isCtrl+Shift+L(used by Bitwarden and LastPass). If the team is open to it, reassigningCtrl+Shift+Lfromopen-larger-windowtoautofillin a follow-up would align with user expectations from competing password managers.Dropdown approach (not direct autofill): Opens the dropdown instead of auto-filling the top match. This is safer, gives the user control when multiple credentials match, and reuses the existing dropdown infrastructure with minimal new code.
Safari excluded: Safari does not support the
browser.commandsAPI. The command listener is already gated byBUILD_TARGET !== 'safari'inworker/index.ts.Test plan
handleExtensionCommand(4 tests passing):open-larger-windowcommandAUTOFILL_TRIGGERto active tab forautofillcommandCtrl+Shift+Uon a login page → dropdown opens on first login fieldCtrl+Shift+Uon a page with no login form → nothing happensCtrl+Shift+XandCtrl+Shift+Lstill work as before