Repository navigation
test(query-engine): SQL quantile roll-up over several windows - #872
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #871.
Adds
sql_quantile_by_subset_over_several_windows_equals_the_merged_sketchtorollup_tests.rs:SELECT service, QUANTILE(0.9, value) … DATEADD(s, -300, NOW()) … GROUP BY service, served by a DDSketch grouped by(endpoint, service)with 60 s tumbling windows, must equal the p90 of one sketch over all the data. This is the shape--planner saved(#866) writes for sketch-bench's p99 CUBE; until now only the HLL roll-up was tested through SQL, over one window.The query time is a multiple of the window, as the e2e client floors eval times to the repeat interval. At an unaligned time (the module's 1000 s) the windows fall off the epoch grid and the engine finds no local data; that is expected, not tested here.
Testing:
cargo test -p query_engine_rust --lib rollup_tests: 12 pass.🤖 Generated with Claude Code