Skip to content

feat(query-engine): roll up single-subpopulation aggregations to a coarser grouping - #853

Merged
milindsrivastava1997 merged 1 commit into
mainfrom
839-2-engine-rollup
Oct 13, 2026
Merged

milindsrivastava1997 merged 1 commit into
mainfrom
839-2-engine-rollup

Conversation

@milindsrivastava1997

Copy link
Copy Markdown
Contributor

Replacement for automatically closed #848 after its stacked base branch was squash-merged and deleted. Rebased onto main; preserves #848's roll-up change.

…arser grouping

A query grouped by Q can now read an aggregation grouped by G ⊋ Q. Right
after the store read, every G-group is re-keyed by its projection onto Q,
so the per-step merge folds all subpopulations of an output group into one
state before the statistic is queried. Instant and range queries, and all
query languages, share this path.

Only Sum, MinMax, DatasketchesKLL, DDSketch and HLL roll up. A query whose
grouping isn't a subset of the aggregation's, or a roll-up of any other
type, is an error rather than a fall-through. Keyed and top-k aggregations
keep their existing path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@milindsrivastava1997
milindsrivastava1997 merged commit 4b79b69 into main Oct 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant