Repository navigation
test(query-engine): add SQL query support runner - #823
Merged
Merged
Conversation
Plans each SQL suite query in isolation and builds the engine's execution context against that plan, without ingesting data. Each case declares whether it is expected to be supported, so a change in SQL coverage fails the run until the suite is updated. Suites mirror the promql-compliance suites case-for-case, plus a basic suite covering single-layer shapes, time-range forms, and top-k. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
10 tasks
The runner checks plan-path acceptance, not result compliance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
milindsrivastava1997
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a SQL query support runner, a counterpart to
promql-compliancelimited to the plan path: no data is ingested and nothing is executed.asap-query-engine/tests/sql_query_support.rsplans each suite query on its own withSQLController, builds aSimpleEnginefrom that plan, and callsbuild_query_execution_context_sql. A query issupportedwhen both steps succeed.expected: supported | unsupported, so a query that starts or stops being supported fails the test until its entry is updated.asap-query-engine/tests/sql_query_support/*.yaml:basic.yaml, plus one suite per PromQL compliance suite with matching case names. Each file header lists the PromQL cases that were skipped for having no SQL equivalent (counterrate/increase,[10m:]subqueries, bare selector).228 cases: 78 supported, 150 unsupported. Unsupported shapes are tracked in #822.
Per-query report:
cargo test -p query_engine_rust --test sql_query_support -- --nocaptureTest plan
cargo test -p query_engine_rust --test sql_query_support🤖 Generated with Claude Code