Repository navigation
feat(logical-asap-optimization): Example 2 — summary-capability rule and UnivMon frequency statistics - #707
Merged
Merged
Conversation
zzylol
force-pushed
the
stack/g5-example2
branch
from
October 15, 2026 14:49
5db47b1 to
ba664e5
Compare
Each family lists the readouts one of its states answers (Readout: total, item frequency, any quantile rank, distinct count, L2, entropy, top-k), so a planner rule can check that one state serves every consumer's statistic: UnivMon answers its total and every frequency moment, KLL every rank, CountSketch item frequencies and L2, the heap sketches top-k and item frequencies. Exact accumulators are read as finalized values and answer no readout.
Composition sizes each consumer's summary build alone, for its own
target. The summary-capability rule groups the builds of one candidate
that chose the same family over the same input sub-DAG (window, WHERE
and time range included), item and weight, grouping and filter, whose
every reader is an estimate the family answers (the family-capability
table's readouts), and that differ only in size. For every choice, per
group, of no sharing or one subset of two or more members whose sizes
differ (partial sharing included), the subset becomes one build sized
with each parameter's largest value among the members (a KLL's failure
probability and DDSketch's alpha: the smallest), and every guarantee
above it is composed again, so plan selection checks each consumer
against the shared state. Builds of equal size stay the
identical-expression rule's; unshared builds are untouched and no
consumer changes family.
Stage 1 lists each composed candidate, its identical-expression
candidates, then each summary-capability candidate followed by its own
identical-expression candidates, every distinct DAG once. The Pass 2
record (Pass2Candidate) names the shared summaries ("UnivMon for Q1,
Q3") and the shared identical groups.
Example 2 (PromQL stand-in): with #702's sizing the three UnivMons
differ (Q1 a distinct-count heap on 19 layers, Q2 the baseline shape for
entropy, Q3 a one-layer Count Sketch for L2), so the rule offers one
UnivMon for each pair and one for all three, each sized with the
members' largest heap, rows, columns and layers and the smallest
recorded distinct-count failure probability; the third query keeps its
own options. A shared UnivMon whose rows and columns together exceed
asap_sketchlib's hash budget (rows * (ceil(log2 cols) + 1) <= 128) is
not offered, since the library would not build it. The shared UnivMon
stays one build in Stage 2.
#509 Example 2 writes L2(src_ip) and Entropy(src_ip) as SQL idioms over grouped unit counts. The SQL lowering (single query and batch) now names them at the query root as FrequencyL2 / FrequencyEntropy aggregates carrying the query's accuracy target, so Pass 1 offers exact and summary candidates for each: - L2: SQRT(SUM(c * c)) over COUNT(*) per key, only when the product is already Float64 (CAST(c AS DOUBLE) factors or CAST(COUNT(*) AS DOUBLE)). The Int64 product stays relational: SQL integer overflow is observable. - Entropy: -SUM(p * LN(p)) with p = COUNT(*)[*1.0] / SUM(COUNT(*)) OVER () over the complete unordered frame; the IR's bits are converted to nats and SQL's -0.0 is kept. Both require a single non-nullable Bool/Int64/Utf8 key, no HAVING and no measure filter, follow projections only, keep the original output schema, and decide SQL's empty-input NULL by an exact population count joined beside the statistic, never by an estimate. Scaled probabilities, LOG2, partitioned or ordered windows and nullable keys stay relational. Ports the frontend part of #598 (originally #562 and #564).
Exact Cardinality, FrequencyL2 and FrequencyEntropy aggregates had no native implementation, so the exact option of #509 Example 2's three statistics could not execute. - Reduction::Cardinality(cols) counts distinct tuples; a tuple with any NULL is skipped, and grouped key encoding keeps tuple boundaries and folds signed zero and NaN payloads. - Reduction::FrequencyL2(col) and FrequencyEntropy(col) count the unit frequencies of one Bool/Int64/Float64/Utf8 identity column: NULL is skipped, a non-finite float is an error, an empty population gives 0.0, and entropy is in bits, as AggIntent::FrequencyEntropy and UnivMon's readout define it. - The dictionaries are memory-accounted and cooperative. - Logical aggregates bind them: grouped ones (SQL COUNT(DISTINCT)) and per-series range reductions (distinct_over_time, l2_over_time, entropy_over_time), which reduce each series' window samples, restore the run's timestamp and drop the metric name as range functions do. - The analytical cost lowering prices them as hash aggregates. Ports the exact-reducer part of #597 (from #559 and #563).
UnivMon had a kernel but no native DAG state: a build was rejected
("summary family has no native DAG state implementation"), a summary
build accepted only Float64 samples, and Pass 1's UnivMon update (each
value of the item column one unit occurrence) did not bind, so no
UnivMon candidate of #509 Example 2 could execute.
- UnivMon is a native family; its states validate against their
parameters, and one state answers its total, distinct count, L2 norm
and entropy.
- A UnivMon build takes Bool, Int64 and Utf8 identities as type-tagged
key bytes (Int64 above 2^53 stays distinct) besides Float64 samples;
NULL is skipped. Retained heap key bytes count toward state memory.
- A unit-frequency update over one item column binds, for UnivMon and
HLL, as a value-frequency build over that column: grouped (SQL
src_ip) and per series (PromQL sample values).
Ports the UnivMon part of #597 (from #557).
Example 2's SQL Q3 casts its counts to DOUBLE (the design's Int64 SUM(c * c) can overflow and stays relational), and the SQL Q2 and Q3 now lower to the entropy and L2 intents, so the SQL workload has the PromQL stand-in's Pass 1 options. The recognized entropy executes in nats with SQL's -0.0, L2 executes exactly, and both give NULL on empty input, decided by the exact population count.
stage_pipeline plans #509 Example 2: three SQL dashboard panels over the last minute of flows (distinct sources at eps 0.02, entropy at 0.05, L2 at 0.01, delta 0.01), lowered over its flows(ts, src_ip) table. SQL workloads lower every entry, batch and repeating, each with its own accuracy target (lower_sql_batch read only batch entries). The stage-viewer tab 2 row is regenerated from it: 82 plans, 16 from Pass 1, the rest from the identical-expression and summary-capability rules (one UnivMon for each pair of queries and for all three); 6 valid, P1 (all exact) selected at 6.08 per second. The row previously said 8 plans were valid.
…ct inputs and an exactly decided CASE
SQL Example 2's L2 decides the empty-input NULL from an exact population
count cross-joined beside the estimate and a CASE on that count. No
guarantee rule covered the join or the CASE, so every SQL plan with
UnivMon for Q3 was rejected ("the output has no guarantee"), although
the L2 estimate is certified.
- A join (inner, outer or cross) whose inputs are exact but one keeps
that input's guarantee when its predicate reads only exact columns:
which rows match, and how often, then does not depend on an estimate.
A key on the approximate input's columns, a semi- or anti-join, or two
approximate inputs have none.
- A CASE whose operand and conditions are exact keeps its weakest
branch's guarantee; a literal or NULL branch, or a missing ELSE, is
exact. A condition over an approximate value has none.
- A projection over such a join composes each output column this way.
Guarantees are per node, so every column of the approximate input counts
as approximate; column-level tracking (#689) stays the general solution.
A root's default metric (#690) looks through the same shape: a
projection whose CASE value branches read columns (or literals, cast or
not) takes those columns' metric, following them through joins and
row-preserving operators to an aggregate's measure, so SQL's L2 root
resolves to a relative target as the PromQL one does. Any other
expression stays absolute.
…UnivMon With the join and CASE guarantee rules, the SQL Q3 UnivMon plans are valid: 12 of the 82 plans are valid (Q3 exact or UnivMon), 70 invalid (Q1 HLL or UnivMon without a distinct bound, Q2 UnivMon without an entropy bound). P1 (all exact) is still selected at 6.08 per second; UnivMon on Q3 costs 8.08.
…s heaps A build charges a state's memory after every input row, and UnivMon's charge summed the bytes of every key on every layer's heap, so building was quadratic in the heap: a 20,000-key heap on 19 layers over 40,000 keys took 3.3 s in release. The charge now bounds the retained keys by every heap slot holding the longest key seen (tracked on insert, merge and adoption of a decoded sketch), in constant time. A test checks that the charge does not grow with heap occupancy; a timing test (ignored, release) checks the large build.
- A capability group of more than 63 builds is an error: one 64-bit mask enumerates the subsets of at most 63, and the shift was clamped, so a larger group was enumerated wrongly (and took 2^63 steps) instead of refused. - A summary-capability variant whose guarantee composition fails carries its own error, so Stage 1 lists it as a candidate that cannot be composed and keeps the remaining variants; one failure used to drop them all. - shared_size_params no longer claims every sizing bound is monotone (a Count Sketch's collision bound is tighter at a power-of-two width than one column wider); the shared state is checked by composing every guarantee above it again.
…jection over a join A projection's guarantee assumed the error lies only in its child's sample-value column (the column named "value", or the only numeric one). Over a join that column can be an exact input's, so the approximate input's columns were read as exact: projecting sum(m) * 1000 beside the exact side's value composed to the approximate side's absolute error 1, while the truth is 1000. A projection over a join (directly, or through projections, filters, sorts, limits or deduplication) now reads each column's own guarantee (column_guarantees), and a projection over a computed projection over a join, whose columns' guarantees are unknown, has none. Plan selection's operand-domain lookup reads columns the same way. column_guarantees and join_guarantee document their assumption that every approximate node of Stage 1 has an exact row set. Per-column tracking in general is #689.
…ore than 20 builds Every subset of two or more builds of a group is a candidate, 2^n of them; past 20 builds (about a million) the rule returns an error naming the limit instead of enumerating.
…serted Charging every heap slot at the longest key seen overcounts badly: one 1 KB key in a sketch of 19 layers of 20,000 slots was charged 380 MB. Each layer's heap keeps at most one copy of a key, so the retained keys are also bounded by the layers times the bytes of every key inserted (or merged in); the charge takes the smaller bound, still in constant time. asap_sketchlib exposes no eviction hook for an exact running total.
zzylol
force-pushed
the
stack/g5-example2
branch
from
October 15, 2026 15:34
ba664e5 to
463a8e1
Compare
This was referenced Oct 15, 2026
Share one UnivMon across distinct, L2 and entropy; document why those readouts stay uncertified
#596
Closed
Contributor
Author
|
Planned simplifications of this PR's interfaces. They land in the Pass 2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#509 Example 2 asks for one summary serving several computations: one UnivMon over
src_ipfeeding the distinct count, the entropy and the L2 norm of the per-source counts. That needs Pass 2's summary-capability rule, a table of which readouts each family answers, executor support for the exact and UnivMon options of the three statistics, and SQL recognition of the entropy and L2 idioms. This PR consolidates that work (G5 of the upper-stack consolidation).What
Family-capability table (types).
FamilyCapability(from feat(types): family-capability table and executor tumbling pane merges #696) now also lists the readouts one state of each family answers (Readout: total, item frequency, quantile, distinct, L2, entropy, top-k), viaFamilyCapability::answers. UnivMon answers its total and every frequency moment, KLL/DDSketch every rank, CountSketch item frequencies and L2, the heap sketches top-k and item frequencies. Exact accumulators answer no readout.Pass 2 summary-capability rule (logical ASAP optimization). Builds of one candidate that chose the same family over the same input sub-DAG (window,
WHEREand time range included), item, weight, grouping and filter, whose every reader is a readout the family answers, form a group. For every subset of two or more members whose sizes differ (partial sharing), the rule adds a candidate in which that subset is one build. The build is sized with each parameter's largest value among the members; KLL's failure probability, DDSketch's α and UnivMon's recorded distinct-count failure probability take the smallest value. Every guarantee above it is composed again, so plan selection checks each consumer against the shared state. Builds of equal size stay with the identical-expression rule. Unshared builds are untouched, and no consumer changes family.SQL frontend.
SQRT(SUM(c * c))over Float64 counts (CAST(c AS DOUBLE)orCAST(COUNT(*) AS DOUBLE)) lowers toFrequencyL2.-SUM(p * LN(p))withp = COUNT(*) / SUM(COUNT(*)) OVER ()lowers toFrequencyEntropy. Both keep the original output schema and decide SQL's empty-input NULL from an exact population count joined beside the statistic. The Int64SUM(c * c)stays relational, because integer overflow is observable.Executor.
Cardinality,FrequencyL2andFrequencyEntropyreducers, memory-accounted and cooperative.asap_sketchlibhas no eviction hook, so a stream of long keys is still overcounted. A build charges memory after every row, so walking the heaps made ingestion quadratic in the heap: 3.3 s for a 20,000-key heap on 19 layers over 40,000 keys, in release.Guarantees through SQL's NULL decision. SQL's L2 and entropy outputs decide the empty-input NULL from an exact population count cross-joined beside the estimate, through a
CASEon that count. Two narrow rules now cover that shape:A join (inner, outer or cross) keeps the approximate input's guarantee when every other input is exact and its predicate reads only exact columns. A key on the approximate input's columns, a semi- or anti-join, or two approximate inputs have none.
A
CASEwhose operand and conditions are exact keeps its weakest branch's guarantee; a literal or NULL branch is exact. A condition over an approximate value has none.A projection over a join (directly or through row-preserving operators) reads each column's own guarantee, not the child's sample value. Plan selection's operand-domain lookup does the same. A projection over a computed projection over a join has no guarantee.
These rules assume every approximate node of Stage 1 has an exact row set: top-k estimates, whose rows are approximate, have no bound.
Guarantees are per node, so every column of the approximate input counts as approximate. Column-level tracking (Track exact vs approximate per column so key-only filters over approximate inputs keep their guarantee #689) stays the general solution.
Root metric through SQL's NULL guard (Accuracy targets and guarantees: three error metrics (absolute, relative, rank), a shared AccuracySpec, and metric-aware satisfies #690 API). A root's default metric now looks through a
CASEwhose value branches read columns or (cast) literals. It follows those columns through joins and row-preserving operators to the aggregate's measure, so SQL Q3 resolves to a relative target like the PromQL L2 root. Any other expression stays absolute.Ported to Accuracy targets and guarantees: three error metrics (absolute, relative, rank), a shared AccuracySpec, and metric-aware satisfies #690/feat(types): three error metrics, a shared AccuracySpec and metric-aware satisfies (#690) #708.
RequestedAccuracyandAccuracyTarget::exact().Devtools. A
stage_pipeline --example planner-layering-2example. The stage-viewer tab 2 row is regenerated from it: it said 64 plans with 8 valid; it now lists 82 plans with 12 valid.How
asap_aware_cse::capability_groups/summary_capability_variantsenumerate the subsets (mixed-radix over groups, binary-counter subsets within a group).estimators::shared_size_paramscomputes the per-parameter shared size. Not every bound is monotone in its parameters: a Count Sketch's collision bound is tighter at a power-of-two width than one column wider. So the shared state is not assumed to meet each target; every guarantee above it is composed again and plan selection checks it. It returns no shared UnivMon when the combined rows and columns exceedasap_sketchlib's hash budget (rows · (⌈log2 cols⌉ + 1) ≤ 128, from feat(planner): certify UnivMon L2 and distinct count on the certifiable sketchlib estimators #702), since the library would not build that shape.MAX_GROUP_MEMBERS): every subset is a candidate, about a million at 20. A variant whose guarantee composition fails is listed as a candidate that cannot be composed, and the other variants go on.Pass2Candidate) names the shared summaries, e.g. "UnivMon for Q1, Q3".estimators/univmon.rs); this PR reuses them and adds no certification of its own.Key code interfaces added / modified
crates/types/src/post_asap/family_capability.rs,post_asap/mod.rscrates/asap-aware-mapping/src/asap_aware_cse.rscrates/asap-aware-mapping/src/pass/stage1_to_stage3.rs,pass/mod.rscrates/asap-aware-mapping/src/per_computation_candidates.rs,accuracy/estimators/mod.rscrates/asap-physical-operators/src/operators/aggregate/mod.rscrates/asap-physical-operators/src/summary_kernels/factory.rs,univmon.rscrates/asap-physical-operators/src/capability.rs,values.rscrates/frontend-sql/src/frequency.rs,lib.rscrates/devtools/src/planner_layering_examples.rs,planning_stages.rs,bin/stage_pipeline.rsUsage, end to end (numbers from
stage_pipeline --example planner-layering-2 --out run.jsonat this PR's merge commit2c674f69):Before this PR
After this PR
planner-layering-2, regenerated row indocs/user_guide_docs/stage-viewer.md):Verification
cargo nextest runon asap-types, asap-aware-mapping, asap-frontend-sql, asap-frontend-promql, asap-physical-operators, asap-integration-tests and asap-devtools: all pass. The suite includesplanner_layering_example2,sql_frequency,frequency_execution,sql_cardinality,univmon_execution,precompute_raw_samplesandstage_pipeline. Three Example 2 tests stay#[ignore]d, each naming its missing feature: an entropy accuracy model, specialized entropy and L2 families, and materializing the shared UnivMon (Stage 2 materialization: ingestion vs query time per summary #604).shared_size_paramsrefuses a shared UnivMon past the hash budget.memory_charge_does_not_grow_with_heap_occupancy). The timing checkper_row_memory_charge_of_a_large_build_is_fastis ignored by default; run it in release. It took 3.3 s before the fix and passes well under its 0.5 s bound after.a_group_past_20_members_is_an_error).projection_over_a_join_reads_each_columns_guarantee):sum(m) * 1000beside an exact column composes to absolute error 1000. It composed to 1 before the fix.root_metric_looks_through_a_null_guard_to_its_statistic).one_long_key_is_charged_about_once). It was charged 380 MB before the fix.stage3_plan_selection_accepts_sql_univmon_l2_beside_its_exact_population_count).CASEtesting an approximate column give none.cargo fmt --all -- --checkandcargo clippy --workspace --all-targets --all-features --locked -- -D warnings: clean.Limitations and follow-ups
SketchParamsequality ignores KLL's and UnivMon's recorded failure probabilities. Builds of equal shape but different δ therefore stay with the identical-expression rule, which is conservative: the state is the same.Resultmakes it impossible for one failure to drop the others.answersmetric check from Stage 3: satisfies checks the error metric #627 is folded into Accuracy targets and guarantees: three error metrics (absolute, relative, rank), a shared AccuracySpec, and metric-aware satisfies #690. feat(executor): execute the exact SQL entropy fallback; Example 2 status #599'ssql_window_sum/lnare left out. devtools: stage_pipeline examples planner-layering-2 and 4b #613's Example 4b is not part of this PR.Supersedes
This PR supersedes #595, #596, #597, #598, #599, #621 and #613; they are closed unmerged. #621's UnivMon L2 certification already landed in #702.