Repository navigation
refactor(planner): name the planner pipeline Stage 1 to Stage 3 and its fields by stage - #675
Merged
Merged
Conversation
…ts fields by stage Follow-up to the review on #674. Pure rename plus docs; behavior unchanged. - pass/stage_pipeline.rs -> pass/stage1_to_stage3.rs; plan_stages -> run_stage1_to_stage3; StagePipelineRun -> Stage1ToStage3Run; StagePipeline -> Stage1ToStage3Pass, registered as "stage1-to-stage3". - Run fields named by stage: stage1_pass1_per_computation, stage1_logical_asap_optimization, stage2_physical_asap_optimization, stage2_pruned, stage3_plan_selection; combinations documented as Stage 1. - Candidate label -> display_name (Logical/Physical/PrunedCandidate and the stage_pipeline JSON key); target_owners -> query_of_target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W7qG9aFyPij5uWsyAJCxDW
This was referenced Oct 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
User review on #674: the pipeline's names did not say which stages they cover ("this covers which stage(s)?", "What does label mean?", "What does owner mean?").
What
Pure rename plus docs; behavior is identical.
pass/stage_pipeline.rs→pass/stage1_to_stage3.rs;plan_stages→run_stage1_to_stage3;StagePipelineRun→Stage1ToStage3Run;StagePipeline→Stage1ToStage3Pass, registry namestage-pipeline→stage1-to-stage3. The module doc now opens with Stage 1 → Stage 2 → Stage 3 from the query-language frontends' roots, with Stage 0 run before it in the facade.stage1_pass1_per_computation,stage1_logical_asap_optimization,stage2_physical_asap_optimization,stage2_pruned,stage3_plan_selection.combinationsstays, documented as the number of Stage 1 whole-workload candidates. Every field doc names its stage.label→display_name(the fn and theLogicalCandidate/PhysicalCandidate/PrunedCandidatefields), documented as a human-readable name used only for display. Thestage_pipelineJSON key changes to match; the dag-viewer on main does not read it. Fixture regenerated: the only changes are the key rename and the resulting key order.target_owners/owner→query_of_target, the index of the query root that first reads each target.asap_planner), tests, devtools, and the pluggable-optimization doc are updated.Key code interfaces added / modified
Renames only; signatures and behavior are otherwise unchanged.
crates/asap-aware-mapping/src/pass/stage1_to_stage3.rs(renamed frompass/stage_pipeline.rs),pass/mod.rs,lib.rscrates/asap-aware-mapping/src/stage2_physical_asap_optimization.rscrates/devtools/src/bin/stage_pipeline.rsCandidate objects in the
stage_pipelineJSON document: key"label"renamed to"display_name".crates/integration-tests/src/lib.rsUsage:
Verification
cargo fmt --all -- --check: cleancargo clippy --workspace --all-targets -- -D warnings: cleancargo nextest run --workspace: 1632 passed, 50 skippedpython3 tools/dag-viewer/test_render.py: 29 tests OKtools/dag-viewer/examples/planner-layering-example1.jsonregenerated: 6label→display_namekeys changed, nothing elseHuman review — do not complete with an agent