Repository navigation
fix: listen to queued asynchronous actions at boot - #478
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A queued async action was only run if the request running it had built an
Action(Async::listen()was called from the Action adapter). A handler registered only in the dispatching request was never run; Action Scheduler marked the job failed with "no callbacks are registered". The provider now callsAsync::listen()at boot.Same code as v13.35.6, found while testing pollora-test on the release. Verified live: with the handler registered only at dispatch,
via('wp-cron')andvia('action-scheduler')both run once. No unit test: the framework suite defines no WordPress functions, soadd_action/has_actioncannot be asserted there.