Skip to content

Fix Sacrifice Support life calculation for totems #10363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Oct 29, 2026
+16 −8
Merged

Fix Sacrifice Support life calculation for totems #10363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Data/Skills/sup_int.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5893,12 +5893,10 @@ skills["SupportSacrifice"] = {
statDescriptionScope = "gem_stat_descriptions",
statMap = {
["support_sacrifice_sacrifice_%_of_current_life"] = {
mod("Multiplier:SacrificePercent", "BASE", nil, 0, 0, { type = "PercentStat", stat = "LifeUnreserved", percent = 1, actor = "parent" }),
skill("sacrificeLifePercent", nil),
},
["support_sacrifice_gain_%_of_sacrificed_life_as_added_chaos_damage"] = {
mod("ChaosMin", "BASE", nil, 0, 0, { type = "Multiplier", var = "SacrificePercent" }),
mod("ChaosMax", "BASE", nil, 0, 0, { type = "Multiplier", var = "SacrificePercent" }),
div = 100,
skill("sacrificeLifeAsChaos", nil),
},
},
qualityStats = {
Expand Down
6 changes: 2 additions & 4 deletions src/Export/Skills/sup_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,12 +814,10 @@ return function(skills, mod, flag, skill)
#skill SupportSacrifice
statMap = {
["support_sacrifice_sacrifice_%_of_current_life"] = {
mod("Multiplier:SacrificePercent", "BASE", nil, 0, 0, { type = "PercentStat", stat = "LifeUnreserved", percent = 1, actor = "parent" }),
skill("sacrificeLifePercent", nil),
},
["support_sacrifice_gain_%_of_sacrificed_life_as_added_chaos_damage"] = {
mod("ChaosMin", "BASE", nil, 0, 0, { type = "Multiplier", var = "SacrificePercent" }),
mod("ChaosMax", "BASE", nil, 0, 0, { type = "Multiplier", var = "SacrificePercent" }),
div = 100,
skill("sacrificeLifeAsChaos", nil),
},
},
#mods
Expand Down
12 changes: 12 additions & 0 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1905,6 +1905,18 @@ function calcs.offence(env, actor, activeSkill)
skillModList:NewMod("PhysicalMax", "BASE", m_floor(output.ManaCost * multiplier), "Sacrificial Zeal", ModFlag.Spell)
end

if skillData.sacrificeLifePercent then
local life
if skillFlags.totem then
life = output.TotemLife
else
life = output.LifeUnreserved
end
local add = m_floor(life * skillData.sacrificeLifePercent / 100 * (skillData.sacrificeLifeAsChaos / 100))
skillModList:NewMod("ChaosMin", "BASE", add, "Sacrifice Support")
skillModList:NewMod("ChaosMax", "BASE", add, "Sacrifice Support")
end

runSkillFunc("preDamageFunc")

if activeSkill.skillTypes[SkillType.Brand] then
Expand Down
Loading