Repository navigation
Add Runeforged and Runemastered variants for Unique items - #2544
Merged
LocalIdentity merged 3 commits intoSep 29, 2026
Merged
Conversation
LocalIdentity
approved these changes
Sep 29, 2026
LocalIdentity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2540.
Description of the problem being solved:
This PR finally adds the default variants that I accidentally broke and did improperly in the original PR. This is now done using the verisium crafts dat table.
This still doesn't allow for selecting a specific base type if they have overlapping names as this is a separate item parsing problem.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: