Repository navigation
Fix crash when using equipping Adonia's Ego - #2543
Merged
LocalIdentity merged 1 commit intoSep 29, 2026
Merged
LocalIdentity merged 1 commit into
LocalIdentity merged 1 commit into
Conversation
getGrantedSkillLevel falls back to level 1 when no level at or below the item's level qualifies. The 0.5.5 export defines some granted skills only at higher levels: Pinnacle of Power, granted by Adonia's Ego, has only level 20. levels[1] is then nil and CalcSetup errors while setting the gem's requirements, so any build with the wand fails to calculate. Fall back to the lowest level the skill defines instead.
LocalIdentity
approved these changes
Sep 29, 2026
LocalIdentity
changed the title
juddisjudd
added a commit
to pobredux/pob-redux
that referenced
this pull request
Sep 29, 2026
…nia's Ego patch (#35) Upstream merged the granted skill level fix as PathOfBuildingCommunity/PathOfBuilding-PoE2#2543. The merged change is the same as `patches/poe2/0002`, so this removes the patch. It then moves the PoE2 pin from `ce566eac4` to the current `dev` head, `e6129c54`. `patches/poe2/0001` (Fist of War, upstream #2538, still open) still applies. ## Upstream commits brought in | Commit | PR | Corpus effect | |---|---|---| | `630bb3d5` | #2543 granted skill level fallback | none (same as the removed patch) | | `9d354ded` | #2547 Geofri's Sanctuary and Sunken Vessel | none | | `07d03a94` | #2546 catalyst box for jewels | none (UI only) | | `3c0de110` | #2537 `utf8.reverse` argument | none | | `75f461f4` | #2542 radius jewel functions accumulating across mod list rebuilds | 8 builds move | | `e6129c54` | #2545 Doedre's Undoing infinite DPS | none | ## Golden moves `bun run golden` on 550 builds: 8 changed, 0 errors. I checked each commit on the 8 builds, and every move comes from #2542. Before that fix, a radius jewel's functions were applied again on each slot mod list rebuild, so the old values were too high. All 8 are Shaman ladder builds (6 Spell Totem / Grim Pillars, 2 Maul). They lose 3.5% to 35% TotalDPS. Some also lose Mana, and one loses Spirit. Every move goes toward the numbers poe.ninja recorded for the build: | Build | poe.ninja TotalDPS | Old | New | |---|---|---|---| | `3a15d10e8425` | 3,749,877 | 5,798,594 | 3,749,877 | | `220d6443ad89` | 2,209,806 | 3,024,042 | 2,209,806 | | `57687f845f27` | 1,148,936 | 1,525,829 | 1,148,936 | | `bf849e791aeb` | 877,003 | 1,231,591 | 877,003 | | `9949389c618e` | 189,962 | 250,218 | 189,962 | | `c560fdd745b5` | 2,961,400 | 3,958,993 | 3,025,280 | | `4fb76d0be1c6` | 142,485 | 147,615 | 142,485 | | `cf902a687ca0` | 88,782 | 95,504 | 88,859 | `golden/poe2.json` is re-accepted. Its header now records the new pin and drops the removed patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
getGrantedSkillLevelreturns level 1 when no level at or below the item's level qualifies. Since the 0.5.5 export (#2505), some granted skills define only higher levels. Pinnacle of Power, granted by Adonia's Ego, has only level 20. This has two effects:CalcSetup.luaatgrantedEffect.levels[level].levelRequirement(attempt to index a nil value). The whole build then fails to calculate.This change falls back to the lowest level the skill defines, so Pinnacle of Power gets level 20.
Steps taken to verify a working solution:
CalcSetup.lua:2167.Link to a build that showcases this PR:
No public link. Any build saved before #2505 with Adonia's Ego equipped reproduces it.
Before screenshot:
CalcSetup.lua:2167: attempt to index a nil value; the build shows no stats.After screenshot:
The build calculates, with Pinnacle of Power at level 20.