Skip to content

Fix radius jewel functions accumulating across mod list rebuilds #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Sep 29, 2026
Merged

Fix radius jewel functions accumulating across mod list rebuilds #2542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Classes/Item.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2660,10 +2660,15 @@ function ItemClass:BuildModListForSlotNum(baseList, slotNum)
end

local jewelData = self.jewelData
-- Rebuild the list from scratch: jewelData is only cleared when the item is reparsed,
-- while this runs again whenever the slot mod list is rebuilt (see GetActiveModListForSlotNum),
-- so appending would apply the jewel's radius functions once more on every rebuild
local funcList = nil
for _, func in ipairs(modList:List(nil, "JewelFunc")) do
jewelData.funcList = jewelData.funcList or { }
t_insert(jewelData.funcList, func)
funcList = funcList or { }
t_insert(funcList, func)
end
jewelData.funcList = funcList
for _, value in ipairs(modList:List(nil, "JewelData")) do
jewelData[value.key] = value.value
end
Expand Down