Repository navigation
Fix DDS sheet code causing image offset issues - #2523
Merged
LocalIdentity merged 4 commits intoSep 29, 2026
Merged
Conversation
Removes the background texture as it was causing a crash on old trees and also doesn't really need to exist as it looks nicer as a smooth colour
LocalIdentity
approved these changes
Sep 29, 2026
juddisjudd
added a commit
to pobredux/pob-redux
that referenced
this pull request
Sep 30, 2026
Upstream PoB (PathOfBuildingCommunity/PathOfBuilding-PoE2#2523) changed `ddsCoords` in `tree.json`. An entry can now be `[x, y, w, h, layer]` as well as a layer number, because most frame, background and socket art does not fill its DDS layer. pob-sync only read numbers, so it would drop all 272 of these entries: node frames, jewel sockets, group backgrounds, mastery effects and the class hub ring. pob-sync now reads both forms. Atlas rects point at the art inside its layer, and large layers are cropped before they are downscaled. The tree draws each sprite into PoB's fixed node sizes, so the padding used to push frames a few pixels up and to the left of their icons. Frames are now centred on their icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR fixes various padding issues in the program's graphics. These come from us assuming that the DDS sheets are filled edge to edge with no padding, which isn't true. This is fixed by taking the UI image size (if it exists), calculating UV coords using the size, and passing it to DrawImage to ignore the padding.
These are also added to the export files, which is why the loc is so high.
Steps taken to verify a working solution:
Before screenshot:
After screenshot:
In-game for reference: