Repository navigation
Fix gem level behaviour of support granted skills - #2521
Merged
LocalIdentity merged 4 commits intoSep 29, 2026
Merged
Conversation
added 2 commits
September 29, 2026 18:02
When having multiple skills with support effects it could use the wrong main skill as a level reference
LocalIdentity
approved these changes
Sep 29, 2026
awlego
added a commit
to awlego/PathOfBuilding-PoE2
that referenced
this pull request
Oct 11, 2026
Conflict in CalcSetup.lua resolved to upstream: PathOfBuildingCommunity#2521 defers every support-granted active skill and has it inherit the supported skill's level, which supersedes the local Hayoxi lineage level-mirroring pass. The lineage tag conversion and trigger cadence code is kept. Adapt the Time-Lost solver's trade query to PathOfBuildingCommunity#2502's requester callback contract (filters-only table instead of a JSON string), passing a price sort through since the query has no weight group for statgroup.0. Regenerate ModCache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This fixes an issue reported on Reddit where Chaos Mastery linked with Despair and Doedre's Undoing doesn't increase damage. This seems to have been caused by the support granted skill code only copying the base parent gem level, which doesn't include e.g. support gem or item +levels.
The calc tab also assumed level 1 on the gem.
Now, the gem level is just from another active skill, and the calc tab shows that level while hiding modifiers.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe2/pob/28c7b
Before screenshot:
After screenshot: