Skip to content

Downgrade NServiceBus.Transport.AzureServiceBus to 6.5.0 - #6044

Closed
mauroservienti wants to merge 1 commit into
masterfrom
revert-asb-6.6.0
Closed

mauroservienti wants to merge 1 commit into
masterfrom
revert-asb-6.6.0

Conversation

@mauroservienti

Copy link
Copy Markdown
Member

Moves NServiceBus.Transport.AzureServiceBus back from 6.6.0 to 6.5.0, the latest 6.5.x release.

The version was raised by two commits that came in with #5967:

  • f4f5912 moved it from 6.5.0 to 6.6.0-alpha.1
  • bc7a664 moved it from 6.6.0-alpha.1 to 6.6.0

Only the version line is reverted. The receive properties code from #5962 and #5967 uses ReceiveProperties from NServiceBus 10.2.9, not from the transport, so it still compiles. Not verified: whether the transport populates receive properties in 6.5.0. If only 6.6.0 does, the receive properties pseudo-headers and their retry handling have no effect on Azure Service Bus until the transport is upgraded again.

Verification

  • ServiceControl.Transports.ASBS and ServiceControl.Transports.ASBS.Tests build without errors and resolve NServiceBus.Transport.AzureServiceBus 6.5.0.
  • A full local solution build fails with CA2007 errors in the RavenDB persistence projects. The same errors appear on master without this change, so CI is the reference for the full build.

Reverts the package version change from f4f5912 and bc7a664, which moved
it to 6.6.0-alpha.1 and then 6.6.0. The receive properties code from #5962
and #5967 uses the NServiceBus core API and still compiles.
@poornimanayar

Copy link
Copy Markdown
Contributor

There is already an open PR #6042

@mauroservienti

Copy link
Copy Markdown
Member Author

Replaced by #6042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants