Repository navigation
Ravendb upgrade - #5978
Draft
afprtclr wants to merge 8 commits into
Draft
Ravendb upgrade#5978afprtclr wants to merge 8 commits into
afprtclr wants to merge 8 commits into
Conversation
Brings the branch up to date so the retention sweep tests and the RavenDB environment data tests are present alongside the RavenDB 7 upgrade changes. Co-Authored-By: Claude Code <noreply@anthropic.com>
RavenDB 7 removed the 'Logs.Mode' setting (None/Operations/Information) in favour of 'Logs.MinLevel', which takes a Sparrow.Logging.LogLevel name, so the quiet default now reports as "Warn" rather than "Operations". Co-Authored-By: Claude Code <noreply@anthropic.com>
A_cancelled_sweep_keeps_the_errors_of_passes_that_failed_first cancelled from the test thread right after TryStartManualSweep returned. When the failing pass and the empty database let the whole sweep finish before the token was observed, the sweep had genuinely completed and reported Failed rather than Cancelled. Raise the cancellation from inside the sweep instead, by arming the batch-delete interceptor over an event log pass with more than one batch of expired rows, so the cancellation can only land between batches. Check_does_not_expire_with_time advanced the shared fake clock by two hours to prove the alert does not age out, but that also let the hosted sweeper's own timer fire. A sweep against a healthy database succeeded, cleared the reported failure and reset the consecutive failure count, so the check passed. Keep the error retention period unrepresentable so those background sweeps fail too, which is the shape the check exists for. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.