Repository navigation
Uxgrid edge data interpolators - #3012
Open
wyatt-fluidnumerics wants to merge 5 commits into
Open
wyatt-fluidnumerics wants to merge 5 commits into
wyatt-fluidnumerics wants to merge 5 commits into
Conversation
for more information, see https://pre-commit.ci
…ode/Parcels into uxgrid-edge-data-interpolators
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds built in interpolators for edge registered UxGrid data, it also adds testing for the default selection of uxinterpolators during fieldset creation.
The two interpolators match existing built in convention for constant
ZCand linearZFinterpolation, while doing piecewise constant lateral interpolation by averaging edge data to face centers.Checklist
from_ugrid_conventionscrashes with opaqueTypeErrorfor extra variables with unsupported dimension layouts #2674mainfor normal development,v3-supportfor v3 support)AI Disclosure
ZCinterpolator and then asked opus 5.5 to do the matching case for linearZF. I reviewed all code produced by the llm.