Repository navigation
Fix Interpolation and mesh type in test_fesom2_square_delaunay_uniform_z_coordinate_eval() - #3011
Open
wyatt-fluidnumerics wants to merge 12 commits into
Open
wyatt-fluidnumerics wants to merge 12 commits into
wyatt-fluidnumerics wants to merge 12 commits into
Conversation
for more information, see https://pre-commit.ci
…/Parcels into _get_offsets_dictionary-bug
for more information, see https://pre-commit.ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
test_fesom2_square_delaunay_uniform_z_coordinate_eval()by to comparing to the correct interpolator and selecting a default mesh type.This comment on #2674 notes that
test_fesom2_square_delaunay_uniform_z_coordinate_eval()is currently failing due to improper interpolation selection. In this case, p is registered onzcsoUxLinearNodeConstantZCshould be the selected interpolator which turns out to be the case in the code.Correcting the expected interpolator and adding the
mesh='flat'argument during fieldset results in a passing test.#2674 should stay open since it is more focused on interpolator selection of edge registered data, which is not fixed by this PR.
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None Used