Skip to content

Fixing write-in-kernel API: Remove fieldset as argument of particleset - #3001

Merged
erikvansebille merged 2 commits into
Parcels-code:mainfrom
erikvansebille:fix-write-in-kernel-api
Oct 22, 2026
Merged

erikvansebille merged 2 commits into
Parcels-code:mainfrom
erikvansebille:fix-write-in-kernel-api

Conversation

@erikvansebille

Copy link
Copy Markdown
Member

Description

This PR fixes #2641, by removing the fields as an extra argument in particles.write()

Checklist

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.
    • Describe how you used it (e.g., by pasting your prompt):

I used CoPilot with he following prompt: "Can you help me with a solution to #2641? It needs to be very clean and simple, and should not involve making fieldset an argument of particleset - we don't want these kinds of dependencies"

@erikvansebille
erikvansebille enabled auto-merge (squash) October 22, 2026 14:50
@erikvansebille
erikvansebille merged commit c447523 into Parcels-code:main Oct 22, 2026
20 of 21 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Oct 22, 2026
@erikvansebille
erikvansebille deleted the fix-write-in-kernel-api branch October 23, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Give ParticleFile access to the time interval information

2 participants