Repository navigation
Hypothesis-driven testing for combining models into a fieldset - #2997
Merged
erikvansebille merged 5 commits intoOct 22, 2026
Merged
erikvansebille merged 5 commits into
erikvansebille merged 5 commits into
Conversation
Prompt: "Can you help me write a set of hypothesis tests that checks if we can combine models with 0D, 1D, 2D, 3D and/or 4D grids in one fieldset? See also Parcels-code#2054 a…"
VeckoTheGecko
approved these changes
Oct 22, 2026
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
Contributor
There was a problem hiding this comment.
I reviewed this carefully. I think it looks good. Happy for this to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a series of hypothesis-driven tests for combining different dimensionality models into one fields. Note that it was generated by an LLM (see below). This is my first hypothesis-driven test framework, so I'm keen for feedback!
Note also that it doesn't test/fix the issue of models that don't combine X and Y (so e.g an XZ grid), that will come in another PR
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
Prompt: "Can you help me write a set of hypothesis tests that checks if we can combine models with 0D, 1D, 2D, 3D and/or 4D grids in one fieldset? See also #2054 and #2727