Conversation
The documented command passes `-input`, `-draft`, `-indent` and `-output`, but helm-values-schema-json 2.6.0 rejects the single-dash `-input` and errors out. Every chart already has a `.schema.yaml` holding all four settings, which is why the maestrod line was already a bare `helm schema`. Makes all three consistent and says where the settings come from, so the next person does not go looking for flags. Verified by regenerating all three charts with the bare command and getting no diff against the committed schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented way to regenerate
values.schema.jsondoesn't work. It passes-input,-draft,-indentand-output, but helm-values-schema-json 2.6.0 rejects the single-dash-inputand errors out.Every chart already has a
.schema.yamlholding all four settings, which is why the maestrod line was already a barehelm schema. This makes all three consistent and says where the settings come from, so nobody goes hunting for flags.