Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task test-rust-apihas silently stopped excludingprqlc-parser, andtask build-each-cratepasses Cargo package IDs where it means package names. Both read the workspace's crates with:workspace_membersused to hold"<name> <version> (<source>)", so splitting on the space took the name. Cargo now emits opaque package IDs with no space in them, so the split is a no-op and each entry comes out as e.g.path+file:///…/prqlc/prqlc-parser#0.13.15.build-each-cratestill works, because Cargo accepts a full package-ID spec after-p.test-rust-apidoes not: itswithout (splitLines .PACKAGES) "prqlc-parser"compares against the plain name, which no longer appears anywhere in the list, so the crate the task's summary says it excludes is tested anyway.Reading
.packages[].nameunder--no-depsgives the plain names directly —--no-depsrestricts.packagesto the workspace's own crates, which is whatworkspace_memberswas being used for.No changelog entry: this is dev tooling with no user-facing effect. Neither task runs in CI —
build-each-crateis reached only throughtask build-all, and nothing invokestest-rust-api.Rendered commands, before and after
Before, from
task --dry test-rust-api:After:
prqlc-parseris absent from the second, as the task's summary intends.