Skip to content

fix(image): correct named symbol rendering - #1213

Merged
Kyle-Ye merged 5 commits into
mainfrom
bugfix/817
Oct 25, 2026
Merged

Kyle-Ye merged 5 commits into
mainfrom
bugfix/817

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Preserve image origins, pixel alignment, and display-list versions when updating symbol positions.
  • Complete vector-symbol rendering through typed update APIs for template images, colors, paths, and masks.
  • Enable NamedImageUITests and update the DPF, ORB, and OCG dependency revisions.

Validation: Earlier local iOS 18.5 snapshot checks passed four tests with one existing skip. Current source syntax checks and dependency resolution pass.

Refs #817.

Dependency

@github-actions github-actions Bot added area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: tests Test coverage, test infrastructure, snapshots, or test-only changes. labels Oct 24, 2026
@Kyle-Ye

Kyle-Ye commented Oct 24, 2026

Copy link
Copy Markdown
Member Author

/uitest osui-iag update only-testing=OpenSwiftUIUITests/NamedImageUITests

@github-actions github-actions Bot added area: graphics Color, shape, gradient, image, symbols, and graphics primitives. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. impact: visual-diff Visual mismatch, screenshot diff, or rendering fidelity issue. type: bug Something is not working correctly. labels Oct 25, 2026
@Kyle-Ye Kyle-Ye changed the title test: enable named image UI tests fix(image): correct named symbol rendering Oct 25, 2026
@Kyle-Ye

Kyle-Ye commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

/uitest osui-iag update only-testing=OpenSwiftUIUITests/NamedImageUITests

@tuist

tuist Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 0e517b98d

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 1m 48s 97d44af37

@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 1.81818% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.30%. Comparing base (c306403) to head (8034650).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...OpenSwiftUICore/Render/InterpolatableContent.swift 0.00% 34 Missing ⚠️
...enSwiftUICore/View/Image/SymbolRenderingMode.swift 0.00% 18 Missing ⚠️
...tUICore/Shape/ShapeStyle/ShapeStyleRendering.swift 0.00% 1 Missing ⚠️
...ces/OpenSwiftUICore/View/Image/GraphicsImage.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
- Coverage   31.31%   27.30%   -4.02%     
==========================================
  Files         968      902      -66     
  Lines       78371    66340   -12031     
==========================================
- Hits        24543    18114    -6429     
+ Misses      53828    48226    -5602     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye

Kyle-Ye commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

/uitest macos osui-iag update only-testing=OpenSwiftUIUITests/NamedImageUITests

@Kyle-Ye

Kyle-Ye commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

/uitest macos osui-iag update only-testing=OpenSwiftUIUITests/NamedImageUITests

@Kyle-Ye
Kyle-Ye merged commit e8092bf into main Oct 25, 2026
6 of 8 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/817 branch October 25, 2026 17:40
@Kyle-Ye Kyle-Ye linked an issue Oct 25, 2026 that may be closed by this pull request
@Kyle-Ye Kyle-Ye added this to the 0.25.0 milestone Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Color, shape, gradient, image, symbols, and graphics primitives. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. impact: visual-diff Visual mismatch, screenshot diff, or rendering fidelity issue. type: bug Something is not working correctly. type: tests Test coverage, test infrastructure, snapshots, or test-only changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable NamedImageUITests test case

1 participant