Skip to content

fix: prevent AppKit button metrics crash on macOS 26 #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 1 commit into from
Oct 20, 2026
Merged

fix: prevent AppKit button metrics crash on macOS 26 #1201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Sources/OpenSwiftUI/View/Control/Button/AppKitButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,10 +458,29 @@ extension NSButton {
var content = NSEdgeInsetsZero
Update.syncMain {
if isBordered {
#if OPENSWIFTUI_ATTRIBUTEGRAPH
if #available(macOS 26.0, *) {
// AppKit's Amber support reads system SwiftUI attributes on macOS 26+.
// OpenSwiftUI uses a separate AG namespace, so suspend dependency
// tracking during this call to avoid a cross-namespace input.
Graph.withoutUpdate {
_ = _getIntrinsicArtworkSize(
&size, alignmentRectInsets: &alignment,
idealContentInsets: &content, maxContentInsets: nil
)
}
} else {
_ = _getIntrinsicArtworkSize(
&size, alignmentRectInsets: &alignment,
idealContentInsets: &content, maxContentInsets: nil
)
}
#else
_ = _getIntrinsicArtworkSize(
&size, alignmentRectInsets: &alignment,
idealContentInsets: &content, maxContentInsets: nil
)
#endif
}
}
let alignmentInsets = EdgeInsets(top: alignment.top, leading: alignment.left, bottom: alignment.bottom, trailing: alignment.right)
Expand Down
Loading