Skip to content

fix: correct hierarchical style resolution and level conversion - #1195

Merged
Kyle-Ye merged 3 commits into
fix/game2048-insetfrom
fix/game2048-shape-style
Oct 19, 2026
Merged

Kyle-Ye merged 3 commits into
fix/game2048-insetfrom
fix/game2048-shape-style

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Resolve hierarchical primary styles from the base style to prevent recursive style resolution.
  • Correct level validation and truncating level conversion for content style IDs.
  • Add regression coverage for level boundaries, secondary colors, and nested hierarchical styles.

Stack

Depends on #1194

Related to OpenSwiftUIProject/OpenSwiftUI-2048#1.

@github-actions github-actions Bot added area: graphics Color, shape, gradient, image, symbols, and graphics primitives. type: bug Something is not working correctly. labels Oct 19, 2026
@Kyle-Ye
Kyle-Ye added this pull request to stack #1198 October 19, 2026 16:49
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.86%. Comparing base (8299514) to head (ac881b2).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           fix/game2048-inset    OpenSwiftUIProject/OpenSwiftUI#1195      +/-   ##
======================================================
+ Coverage               29.78%   29.86%   +0.08%     
======================================================
  Files                     950      950              
  Lines                   76138    76136       -2     
======================================================
+ Hits                    22675    22736      +61     
+ Misses                  53463    53400      -63     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 1m 7s b2a1e1392

@Kyle-Ye
Kyle-Ye merged commit 477918f into main Oct 19, 2026
6 of 7 checks passed
@Kyle-Ye
Kyle-Ye deleted the fix/game2048-shape-style branch October 19, 2026 17:11
Kyle-Ye added a commit that referenced this pull request Oct 19, 2026
* fix: resolve hierarchical primary style from base

* test: cover hierarchical shape style resolution

* test: tag hierarchical style regression tests as aigc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Color, shape, gradient, image, symbols, and graphics primitives. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant