Skip to content

fix: prevent AppKit button metrics crash on macOS 26 - #1201

Merged
Kyle-Ye merged 1 commit into
mainfrom
fix/macos26-button-metrics
Oct 20, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
fix/macos26-button-metrics

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Summary

Close OpenSwiftUIProject/Game2048#1

  • Prevent an AttributeGraph namespace assertion when AppKit button metrics read system SwiftUI attributes during an OpenSwiftUI update on macOS 26 and later.
  • Suspend dependency tracking only around the AppKit metrics call when the AttributeGraph backend is active, preserving the existing path for earlier systems and other backends.

Validation: Swift syntax checks pass with and without the AttributeGraph compilation condition. The final guarded change has not been rebuilt or run.

@Kyle-Ye
Kyle-Ye requested a review from Mx-Iris as a code owner October 20, 2026 18:51
@tuist

tuist Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 6c739a231

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 1m 31s 6c739a231

@Kyle-Ye
Kyle-Ye merged commit 8362d9b into main Oct 20, 2026
5 of 7 checks passed
@Kyle-Ye
Kyle-Ye deleted the fix/macos26-button-metrics branch October 20, 2026 19:01
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.96%. Comparing base (da91cd9) to head (0235a65).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...OpenSwiftUI/View/Control/Button/AppKitButton.swift 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    OpenSwiftUIProject/OpenSwiftUI#1201      +/-   ##
==========================================
+ Coverage   29.95%   29.96%   +0.01%     
==========================================
  Files         950      950              
  Lines       76140    76150      +10     
==========================================
+ Hits        22804    22815      +11     
+ Misses      53336    53335       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye added type: bug Something is not working correctly. platform: macOS macOS-specific behavior or support. area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. impact: crash Crash, assertion, or fatal runtime failure. labels Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. impact: crash Crash, assertion, or fatal runtime failure. platform: macOS macOS-specific behavior or support. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS 26: AppKit button metrics crash with the AttributeGraph backend

1 participant