Skip to content

fix: preserve inset content layout and view lists - #1194

Merged
Kyle-Ye merged 2 commits into
mainfrom
fix/game2048-inset
Oct 19, 2026
Merged

Kyle-Ye merged 2 commits into
mainfrom
fix/game2048-inset

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Preserve child views when safeAreaInset and safeAreaPadding build a view list.
  • Keep primary and inset content identities separate and forward the layout computer.
  • Add regression coverage for view-list counts, implicit IDs, and content sizing.

Related to OpenSwiftUIProject/OpenSwiftUI-2048#1.

@github-actions github-actions Bot added area: layout Layout, geometry, safe area, alignment, stacks, or sizing. type: bug Something is not working correctly. labels Oct 19, 2026
@Kyle-Ye
Kyle-Ye added this pull request to stack #1198 October 19, 2026 16:49
@tuist

tuist Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
Unknown ⏳ 7 164c57424
OpenSwiftUI ✅ 7 164c57424

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 49.4s 164c57424

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.78%. Comparing base (6ee61ca) to head (8299514).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    OpenSwiftUIProject/OpenSwiftUI#1194      +/-   ##
==========================================
+ Coverage   29.44%   29.78%   +0.33%     
==========================================
  Files         950      950              
  Lines       76137    76138       +1     
==========================================
+ Hits        22417    22675     +258     
+ Misses      53720    53463     -257     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 9b43615 into main Oct 19, 2026
7 checks passed
@Kyle-Ye
Kyle-Ye deleted the fix/game2048-inset branch October 19, 2026 17:11
Kyle-Ye added a commit that referenced this pull request Oct 19, 2026
* fix: preserve inset modifier view-list construction

* test: tag inset regression tests as aigc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: layout Layout, geometry, safe area, alignment, stacks, or sizing. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant