Repository navigation
fix(packaging): use Swift targets as library product roots - #35
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 11 11
Lines 371 371
=====================================
Misses 371 371 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Kyle-Ye
force-pushed
the
optimize/orb_link
branch
from
October 14, 2026 18:16
4a4331c to
5d6132e
Compare
Kyle-Ye
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
OpenRenderBoxandOpenRenderBoxShimsas the sole root targets of their respective library products. Keep the Cxx targets as dependencies of the Swift wrappers so consumers no longer linkOpenRenderBoxShimsCxxdirectly alongsideOpenRenderBoxShims.This removes the duplicate static-link warning in the OpenSwiftUI Example project. Regenerate
Package.resolvedwithout changing dependency versions or revisions.