Skip to content

fix(display-list): make moveContents nonoptional - #34

Merged
Kyle-Ye merged 1 commit into
mainfrom
fix/move-contents-nullability
Oct 11, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
fix/move-contents-nullability

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 11, 2026

Copy link
Copy Markdown
Member

Make ORBDisplayList.moveContents nonoptional in both the Objective-C header and the Swift fallback declaration. Update the DarwinPrivateFrameworks pin to the merged nullability correction.

The display list tests now use the nonoptional result and cover empty lists and repeated moves. All six focused compatibility tests passed against RenderBox on macOS; Swift import checks passed for macOS and iOS Simulator.

Dependency

@Kyle-Ye
Kyle-Ye merged commit 9f76f89 into main Oct 11, 2026
4 checks passed
@Kyle-Ye
Kyle-Ye deleted the fix/move-contents-nullability branch October 11, 2026 16:58
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (a5b6045) to head (df629d7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenRenderBox/Render/ORBDisplayList.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #34   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         11      11           
  Lines        371     371           
=====================================
  Misses       371     371           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants