Skip to content

fix: use subgraphOrNil across graph backends - #244

Merged
Kyle-Ye merged 1 commit into
mainfrom
bugfix/observation
Sep 26, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
bugfix/observation

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 26, 2026

Copy link
Copy Markdown
Member

Expose the optional subgraph getter as subgraphOrNil across OpenAttributeGraph and its graph adapters. Remove the Compute shim that always returned nil so callers use Compute's existing getter.

Update the compatibility test call and the DPF CI fallback revision to include the matching Swift API rename. The C symbol remains unchanged.

Dependency

@github-actions github-actions Bot added bug Something isn't working test related labels Sep 26, 2026
@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.83%. Comparing base (1d8e762) to head (5d1cfd6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   31.83%   31.83%           
=======================================
  Files          71       71           
  Lines        2629     2629           
=======================================
  Hits          837      837           
  Misses       1792     1792           
Flag Coverage Δ
macos 10.15% <ø> (ø)
ubuntu 12.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenAttributeGraph-Package ❌ 4 144d67a91

Failed Tests ❌

  • OpenAttributeGraph-Package: 1 failed test (View all)

  • testMode3() · OpenAttributeGraphCompatibilityTests · DebugServerTests
    (host → "169.254.61.167").hasPrefix("192.168")

Builds 🔨

Scheme Status Duration Commit
OpenAttributeGraph ✅ 4.1s 144d67a91
OpenAttributeGraph-Package ✅ 13.1s 144d67a91

@Kyle-Ye
Kyle-Ye merged commit 9ae4ffe into main Sep 26, 2026
10 of 11 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/observation branch September 26, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant