You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Rename the *_array locals to say whether they are a vector or a... #336
Rename the *_array locals to say whether they are a vector or a matrix
Second of the three parts of #147 (Refactoring part III). Stack it on the pull request from branch agent/147-refactoring-part-iii (typed empty containers). The va naming is the third part and comes after this one.
#147 asks to replace every array in a name with vector (1D) or matrix (2D). ufechner7 suggested the suffix _vec for a 1D vector on that thread, and Bart agreed as long as the naming is consistent everywhere. A survey of main at 2b312ea found 22 identifiers and 241 occurrences, all of them locals, positional arguments, or the private calc_norm_array!. None is exported, a struct field, or a keyword, so no public API moves.
The struct fields holding the same data already use _dist (VSMSolution._x_airf_dist, _va_dist, _chord_dist). Decide whether the locals follow the fields or the suffix. A per-panel quantity reads as _dist whether it is 1D or 2D, and that decision belongs in the PR card. There are no 3D names; AIC and SectionAero.cp/cf are Array{T,3} fields and keep their names.
Also noticed: test/body_aerodynamics/test_body_aerodynamics.jl:66-67 and :101-102 size va_norm_array/va_unit_array with length(coord) on a matrix, which counts elements rather than rows.
Renaming the 22 *_array locals to _dist (per-panel, 1D or P×3), which matches the struct fields and the _dist convention already stated at the top of solver.jl. calc_norm_array! becomes calc_norm_dist!, and force_array/moment_array (one 3-vector each) become force/moment. Stacked on #338. Leaving every va name other than the _array suffix to #337.
The red local CI run on be131ba was not the code. It was killed after 3 min (SIGTERM during test_settings.jl) and then failed with IOError: cd(".../VortexStepMethod.jl-336/test"): no such file or directory, because #341 merged at 22:08Z and the worktree was removed while the run was still going. The same commit passed two full local runs (8 min, exit 0), all 6 checks on #341, and main CI on 246237a. Nothing to change.
Activity
1-Bort-1 commentedon Sep 16, 2026
Renaming the 22
*_arraylocals to_dist(per-panel, 1D or P×3), which matches the struct fields and the_distconvention already stated at the top of solver.jl.calc_norm_array!becomescalc_norm_dist!, andforce_array/moment_array(one 3-vector each) becomeforce/moment. Stacked on #338. Leaving everyvaname other than the_arraysuffix to #337.9 remaining items
1-Bort-1 commentedon Sep 16, 2026
The red local CI run on be131ba was not the code. It was killed after 3 min (SIGTERM during test_settings.jl) and then failed with
IOError: cd(".../VortexStepMethod.jl-336/test"): no such file or directory, because #341 merged at 22:08Z and the worktree was removed while the run was still going. The same commit passed two full local runs (8 min, exit 0), all 6 checks on #341, and main CI on 246237a. Nothing to change.