Skip to content

Backport 2362 - #2424

Merged
jan-cerny merged 1 commit into
OpenSCAP:maint-1.3from
Mab879:2362_maint_1_3
Oct 5, 2026
Merged

jan-cerny merged 1 commit into
OpenSCAP:maint-1.3from
Mab879:2362_maint_1_3

Conversation

@Mab879

@Mab879 Mab879 commented Oct 4, 2026

Copy link
Copy Markdown
Member

Backport #2362

Several parse loops never made progress on unexpected/truncated input,
spinning forever (DoS).

- CPE dict/lang: `while (localname != TAG)` loops spun at EOF (localname
  becomes NULL / reader stops advancing) and on unconsumed child nodes in
  cpe_item, cpe_generator, cpe_platform, cpe vendor/notes, cpe23 and
  deprecation parsing; cpe_testexpr_parse spun on a nested logical-test with
  an invalid operator. Break on end-of-document and force forward progress.
- XCCDF profile: xccdf_profile_parse / xccdf_parse_remarks could re-read the
  same node forever; added a forward-progress guard and skip non-<remark>
  children.
- DS rds_index: the report-requests/assets/reports loops did `continue`
  without advancing the reader on a non-matching element. Also NULL-safe id
  lookups and guards for unresolved relationship refs.
@Mab879 Mab879 added this to the 1.3.15 milestone Oct 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2026

Copy link
Copy Markdown

@jan-cerny jan-cerny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that the PR is the same as the linked PR and correctly backports the linked PR to the target branch.

@jan-cerny jan-cerny self-assigned this Oct 5, 2026
@jan-cerny
jan-cerny merged commit 60976f6 into OpenSCAP:maint-1.3 Oct 5, 2026
11 checks passed
@Mab879
Mab879 deleted the 2362_maint_1_3 branch October 5, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants