Repository navigation
Backport 2361 - #2423
Merged
Merged
Backport 2361#2423
Conversation
Missing XML attributes/namespaces/text make libxml return NULL, which was then passed to strcmp/atoi/atof or dereferenced. Guard these and make the shared string helpers NULL-tolerant. - common/util.h: oscap_str_startswith()/oscap_str_endswith() return false on a NULL string (matching oscap_strcmp/oscap_streq). - OVAL: guard the optional `version` attribute before atoi() in oval_state, oval_definition, oval_object, oval_variable, oval_resultDefinition; guard the `reported` attribute (oval_directives); guard a NULL frame from a duplicate variable id (oval_varModel). - XCCDF: NULL-safe atof() for empty lower/upper-bound and score elements (value.c, result.c); reject a NULL <TestResult> (benchmark.c); skip a <platform> with no @idref before strlen() (item.c); reject a NULL profile in tailoring (tailoring.c). - DS: NULL-safe id comparisons in sds_index / rds; reject a component with no id as a hash key (ds_rds_session.c).
|
jan-cerny
approved these changes
Oct 5, 2026
jan-cerny
left a comment
jan-cerny
left a comment
Member
There was a problem hiding this comment.
I have confirmed that the PR is the same as the linked PR and correctly backports the linked PR to the target branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #2361