Let repos.json override broken release metadata - #78
Merged
Merged
Conversation
The v0.4.4 release of SDF-Modelica carries `version="0.4.3"` in its `package.mo` annotation, in both the git tag and the release zip-file, so the index named it 0.4.3 and nothing could resolve SDF 0.4.4. Switching the entry from the `Modelica-OpenVendorSpecificLibraries/SDF` stub to the upstream repository also dropped 0.4.0 to 0.4.2, which existed only as `conversion(noneFromVersion=...)` entries on that stub's master branch. Together that left 15 index entries unresolvable: | Library | Versions | Wants SDF | | --------- | ----------------------- | --------- | | AixLib | 0.9.0 - 1.3.0 | 0.4.1 | | AixLib | 1.3.1 - 3.0.0 | 0.4.2 | | AixLib | 3.0.1, 3.0.1-main, main | 0.4.4 | | TRANSFORM | 1.0.0-beta | 0.4.0 | | TRANSFORM | 1.0.0-Before_MSL_4.0 | 0.4.1 | `installPackage` fails outright on those, since `versionsThatProvideTheWanted` comes back empty and the fallback for transitive dependencies only relaxes an exact match when some version claims to provide the wanted one. Neither the annotation nor the tag can be corrected once a release is out, so add `extra-provides` to name versions a release provides beyond the ones its conversion annotation declares, and set the existing `semverTagOverridesAnnotation` for SDF so that the tag wins over the annotation it forgot to bump. The versions SDF 0.4.5 is declared to provide are transcribed from the `conversion` annotation upstream added for 0.4.6, so the entry can be dropped once that is released. `extra-provides` is applied in `genindex` rather than `updateinfo`: `updateinfo` re-crawls a ref only when its sha or zip-file URL changes, so an override stored in rawdata.json would not take effect until upstream happened to push. A version listed here that no release has is reported, not fatal, so that a deleted GitHub release cannot break the index job for every library. Assisted-by: Claude Opus 5 (1M context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.4.4 release of SDF-Modelica carries
version="0.4.3"in itspackage.moannotation, in both the git tag and the release zip-file, so the index named it 0.4.3 and nothing could resolve SDF 0.4.4. Switching the entry from theModelica-OpenVendorSpecificLibraries/SDFstub to the upstream repository also dropped 0.4.0 to 0.4.2, which existed only asconversion(noneFromVersion=...)entries on that stub's master branch.Together that left 15 index entries unresolvable:
installPackagefails outright on those, sinceversionsThatProvideTheWantedcomes back empty and the fallback for transitive dependencies only relaxes an exact match when some version claims to provide the wanted one.Neither the annotation nor the tag can be corrected once a release is out, so add
extra-providesto name versions a release provides beyond the ones its conversion annotation declares, and set the existingsemverTagOverridesAnnotationfor SDF so that the tag wins over the annotation it forgot to bump.The versions SDF 0.4.5 is declared to provide are transcribed from the
conversionannotation upstream added for 0.4.6, so the entry can be dropped once that is released.extra-providesis applied ingenindexrather thanupdateinfo:updateinfore-crawls a ref only when its sha or zip-file URL changes, so an override stored in rawdata.json would not take effect until upstream happened to push. A version listed here that no release has is reported, not fatal, so that a deleted GitHub release cannot break the index job for every library.Assisted-by: Claude Opus 5 (1M context)