Repository navigation
cmake: fix VORTEXM4 guard for DYNAMIC_ARCH - #6117
Open
topolarity wants to merge 1 commit into
Open
topolarity wants to merge 1 commit into
topolarity wants to merge 1 commit into
Conversation
55a10c7 ("Make VortexM4 available in DYNAMIC_ARCH on MacOS only") meant to restrict VORTEXM4 to clang on Darwin, matching 5133aac for the Makefile build and 6f225da for dynamic_arm64.c. But it put the check in the GNU branch, where the compiler can never match "Clang", and left the clang branch adding VORTEXM4 on every non-Windows system. Move the Darwin check to the clang branch, replacing its non-Windows one. On other systems dynamic_arm64.c aliases gotoblas_VORTEXM4 to NEOVERSEN1, so the VORTEXM4 kernels there were built but never used. Darwin itself is unaffected: the Darwin/iOS block below resets DYNAMIC_CORE and adds VORTEXM4 on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Should fix CI on #6088 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick bugfix to #5423 / 55a10c7 . That change intended to make these kernels Darwin-only but landed in the wrong
ifbranch. It checked for Clang under the GCC branch of the CMake file.This was working accidentally because the kernel was built but never linked / used.