Repository navigation
chore(deps): require GitPython >= 3.2.1 for release tooling - #381
Draft
waninggibbon wants to merge 1 commit into
Draft
waninggibbon wants to merge 1 commit into
waninggibbon wants to merge 1 commit into
Conversation
Signed-off-by: Nathy MacKinlay <61921733+waninggibbon@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
requirements-release.txtpins GitPython to== 3.1.62, so the release workflow installs a version affected by the GitPython advisories published since September. The critical and high ones (for example GHSA-f9j4-qggq-h239, GHSA-w8jc-g24h-crhw, GHSA-23mf-xhv8-69c2 and GHSA-83vg-56qc-22m7) are patched only in 3.2.0 and 3.2.1. The open Dependabot bump to 3.1.62 does not cover them.The pin was added because GitPython 3.1.60 removed
Actor.name_email_regex, which python-semantic-release uses. 3.1.61 restored it (deprecated, with removal planned for 4.0), and 3.2.1 still has it.What was the solution? (How)
Replace the exact pin with a floor of
GitPython >= 3.2.1.What is the impact of this change?
This affects only the release tooling. GitPython is not a runtime dependency of the package.
How was this change tested?
In a clean venv with
python-semantic-release == 10.6.*andgitpython == 3.2.1, I ransemantic-release --strict version --printon a full-history clone of mainline. It parsed the commit history and printed0.14.0without thename_email_regexerror.Was this change documented?
No documentation change is needed.
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.