Repository navigation
Add OCI standard label to worker image; drop "v" prefix - #1604
Draft
taylordowns2000 wants to merge 4 commits into
Draft
taylordowns2000 wants to merge 4 commits into
taylordowns2000 wants to merge 4 commits into
Conversation
metadata-action's default latest=auto skips pre-release tags, so an rc build no longer moves latest. Lightning reads latest's version label to find the newest worker release and reports nothing when that label is a pre-release. Also ignore the junk @openfn/ws-worker@v0.0.* tags when looking for the tag on HEAD, since their v fails the version check. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7ZyHRBAuQApTjnkyVvcCn
taylordowns2000
changed the title
When publish.yaml calls this workflow, github.event_name is the caller's `push` and github.ref_name is `main`, so the push branch read `main` as the tag and failed the version check on every merge. The tag on HEAD covers both cases: a pushed tag checks out the tagged commit, and the publish run builds the commit `changeset tag` just tagged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7ZyHPsP464w6oqJZcGSRg
taylordowns2000
changed the title
taylordowns2000
changed the title
taylordowns2000
changed the title
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worker images are now tagged without the
vprefix (openfn/ws-worker:1.31.0, notv1.31.0), to match Lightning images after https://github.com/OpenFn/deployment/pull/560. Each image also gets the standard OCI labels, includingorg.opencontainers.image.version, which the Lightning update check in OpenFn/lightning#5265 reads.Changes
vin image tags. The Docker tag, and the check for whether that tag is already on Docker Hub, use the version without thev.mainwas. It now uses the@openfn/ws-worker@X.Y.Ztag on the commit being built, and skips the build when there isn't one. This works when the workflow is triggered by a tag push and when it's called frompublish.yaml, wheregithub.refismain, not the tag. It also stops the first run after this PR from rebuildingmainas1.30.0, since onlyv1.30.0exists on Docker Hub. The old@openfn/ws-worker@v0.0.*test tags are ignored.docker/metadata-actiongenerates the tags and the OCI labels: version, revision, source, created, and so on.latestonly moves for full releases. Prereleases no longer overwrite it. Before, every build pushedlatest:1.20.0-rc1waslatestfor about two hours on 2025-12-10, and earlier RCs look to have held it for longer (1.9.0-rc1for about nine days in January 2025).Heads up
From the next worker release, image tags have no
v. ExistingvX.Y.Ztags stay on Docker Hub and keep working, and git tags and npm versions don't change. Anyone bumping image pins, by hand or with Renovate, Dependabot, Flux or Argo, needs to use the new format; some tools treat the prefix as part of the tag format and will stop offering updates without an error.Testing
dockerize.yamlhas nopull_requesttrigger, so CI can't run it here. The tag lookup was checked against a local scratch repo: an untagged commit skips the build, the oldv0.0.*tags are ignored, and checking out a release tag finds it.After merging:
dockerizejob in that merge's publish run should log "No ws-worker release tag on this commit, skipping build".X.Y.Zwith nov,latestshould point at it, and the label should match:No changeset: this only changes the workflow, not a published package.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy