Skip to content

Add support for using an environment for the upload step #37

Closed

Description

@Cadair

It would be cool if you could specify what environment to use just for the upload step rather than the current situation where you have to specify it for the whole publish workflow.

This would allow someone to approve the upload after all the builds complete.

Activity

  1. ConorMacBride commented on Apr 6, 2022

    @ConorMacBride
    Member

    Unless the job environment input has a default value, we would have to duplicate the upload job: one job if an environment input is passed to the workflow and another if it isn't. Is that adding too much complexity? Especially with the Anaconda.org upload step, this would be a lot of duplicated code.

    Also, the upload step for publish_pure_python.yml does not have a separate job for upload. Move to a separate job or apply environment to whole workflow?

  2. Cadair commented on Apr 6, 2022

    @Cadair
    MemberAuthor

    Does referencing an environment which doesn't exist work?!

    Could we use a composite action to reduce the duplication?

  3. Cadair commented on Jan 26, 2024

    @Cadair
    MemberAuthor

    Looking into this a bit more, it seems you can use environment: and with: in the same block, so we will have to add explicit support.

  4. Cadair commented on Mar 23, 2026

    @Cadair
    MemberAuthor

    I'm going to deem this closed by #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions