Repository navigation
Conversation
create cluster without a definition file skipped withdrawal address validation and the insecure-keys-on-mainnet check, and add-validators and create dkg fee recipients were never validated, so a zero or mistyped address on mainnet produced valid deposits. All create/edit paths now share one rule: 0x + 40 hex, all lower or all upper case accepted, mixed case must match EIP-55, zero address forbidden on mainnet/gnosis, stored checksummed. feerecipient sign refuses gas limit 0 and adopting an in-progress registration timestamped more than 5 minutes ahead unless --timestamp confirms it. exit sign with both --validator-public-key and --validator-index checks the index belongs to the pubkey when the beacon node knows it.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4805 +/- ##
==========================================
+ Coverage 67.61% 67.72% +0.10%
==========================================
Files 254 255 +1
Lines 33609 33717 +108
==========================================
+ Hits 22725 22835 +110
+ Misses 10883 10881 -2
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aly-obol
previously approved these changes
Oct 23, 2026
Zero withdrawal and fee recipient addresses are legitimate when the generated deposit data is never used, e.g. splitting existing keys of active validators, or clusters that deposit through their own contracts (EtherFi's mainnet clusters use the zero withdrawal address). Keep the existing zero withdrawal address errors in create dkg and create cluster --definition-file, and only warn on the paths this branch newly validates: create cluster from flags, add-validators and fee recipients.
aly-obol
previously approved these changes
Oct 23, 2026
|
KaloyanTanev
approved these changes
Oct 30, 2026
Comment on lines
+195
to
+199
| if config.SkipBeaconNodeCheck { | ||
| if err := crossCheckValidatorIndex(ctx, eth2Cl, valEth2, valIndex); err != nil { | ||
| return nil, err | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
IIRC the initial idea of using validator indices was precisely for the fact not to require operators to have BN available?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies one address rule across create and edit commands, and makes
feerecipient signandexit signsafer.create clusterwithout--definition-fileskippedvalidateWithdrawalAddrsand the insecure-keys-on-mainnet check (validateDefonly ran on the definition-file path): mainnet + zero withdrawal address +--insecure-keyssucceeded. Now validated.alpha edit add-validatorsandcreate dkgfee recipients were never validated. Now validated before the ceremony / definition is written.create dkgandcreate cluster --definition-file(as before), and only a warning on the paths newly validated here (create clusterfrom flags,add-validators, fee recipients), because it is legitimate when the deposit data is never used: splitting existing keys, or clusters that deposit through their own contracts (EtherFi's mainnet clusters use the zero withdrawal address); a zero fee recipient only warns; addresses stored checksummed (current definition hashing is case-insensitive over address bytes, so hashes are unaffected).feerecipient sign: errors instead of signing gas limit 0; refuses to adopt an in-progress registration with gas limit 0 or a timestamp more than 5 minutes ahead unless--timestampconfirms it. (Feature is being reworked; this only makes it safer.)exit signwith both--validator-public-keyand--validator-index: errors if the beacon node maps the index to a different pubkey; warns and continues if the index is unknown.User-visible: lowercase withdrawal addresses are now accepted where they failed as "invalid checksummed address"; bad-checksum addresses are rejected on more paths, and zero addresses now get a warning on paths that ignored them; error texts changed.
category: bug
ticket: none