Repository navigation
Fix invalid nested <select> when sanitizing <optgroup> - #375
Merged
Merged
Conversation
Author
|
Hi @jmanico |
Member
|
cc @aalmiray @melloware (new leads) |
melloware
approved these changes
Jan 15, 2026
melloware
left a comment
melloware
left a comment
Contributor
There was a problem hiding this comment.
Absolutely approve this is clearly wrong in the code and the correct fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
<optgroup>elements within<select>tags, the HTML sanitizer was incorrectly inserting extra<select>tags, producing invalid HTML.Input:
My option
Broken Output
My option
Root Cause
Simple typo in HtmlElementTables.java
Fixes #358
Note
Similar behavior was observed with but is not included in this PR.