Repository navigation
Fix resource loading in HtmlSanitizerFuzzerTest - #366
Merged
Merged
Conversation
Replace org.apache.commons.codec.Resources.getInputStream() with standard Java class loader resource loading. The commons-codec Resources class uses the thread context class loader which may not have test resources on its classpath in certain environments like GitHub Actions with Maven Surefire. Using getClass().getClassLoader().getResourceAsStream() is more reliable because it uses the same class loader that loaded the test class, guaranteeing the resource will be found.
Merged
jmanico
approved these changes
Dec 19, 2025
Contributor
|
Yep this was the same fix I made in my PR to get it to pass. I will rebase with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the failing
HtmlSanitizerFuzzerTest.testFuzzHtmlParsertest that was causing CI builds to fail.Problem
The test was using
org.apache.commons.codec.Resources.getInputStream()to load the benchmark resource filebenchmark-data/Yahoo!.html. This method uses the thread's context class loader, which may not have the test resources on its classpath in certain execution environments like GitHub Actions with Maven Surefire.Solution
Replace the commons-codec
Resourcesutility with the standard Java class loader approach:This is more reliable because it uses the same class loader that loaded the test class itself, guaranteeing the resource will be found since both the test class and the resource file are in the same classpath scope (
target/test-classes/).Changes
org.apache.commons.codec.Resourcesimportjava.io.InputStreamimportTesting
./mvnw -B verify