Repository navigation
fix(config): assign the commitlint config to a variable before export - #242
Merged
Merged
Conversation
|
@CodeByPeace is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
Owner
|
✨ Thank you, @CodeByPeace! Another great contribution merged! 🚀 We truly appreciate your continued support! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #241
Additionally, at the time of submission of this PR:
The referred issue is not blocked currently
All unittests passed after changes were made
What was wrong. commitlint.config.mjs exported its config object directly, so pnpm lint showed the import/no-anonymous-default-export warning.
What changed. The object is now assigned to a constant named Configuration, and the file exports that. The extends and rules are exactly as before.
How I tested. Before the change, pnpm lint showed 2 warnings, one of them in commitlint.config.mjs. After the change it shows 1, and the one in this file is gone. format:check and tsc pass, and the full test suite passes. I also ran commitlint by hand. A good message exits 0 and a bad one exits 1 with errors, so commit message validation still works.
Left alone. The other warning, an img tag in leaderboard-table.test.tsx, is a different file and not part of this issue.
AI use: written with Claude Sonnet 5.5. I ran and checked every command and test myself.