Activity

1. O2sa

   added

   good first issueGood for newcomersGood for newcomers

   ui

   medium

   api

   feature

   and removed

   good first issueGood for newcomersGood for newcomers

   on Aug 10, 2026
2. 1-DARK commented on Oct 8, 2026

   

   1-DARK

   on Oct 8, 2026

   Contributor

   More actions

   assign me

   🚀React with 🚀1Reacted by github-actions
3. github-actions

   assigned

   1-DARK

   on Oct 8, 2026
4. github-actions commented on Oct 8, 2026

   

   github-actionsbot

   on Oct 8, 2026 – with GitHub Actions

   More actions

   🎉 Issue assigned to @1-DARK! Happy coding!
5. 1-DARK commented on Oct 9, 2026

   

   1-DARK

   on Oct 9, 2026

   Contributor

   More actions

   Worldwide Leaderboard:

   Hi! I've implemented the worldwide leaderboard described in the issue. Before I open the PR, I'd like your feedback on the approach and a few small decisions. Are you satisfied with it, or would you like anything changed?

   What I implemented

   • Worldwide route/state. /leaderboard/worldwide ranks users from all countries together. The DB layer already supported the worldwide slug, so the work was around it.
   • Runtime limit. New variable WORLDWIDE_LEADERBOARD_DISPLAY_LIMIT controls how many users are shown. If it is missing, non-numeric, zero, negative or a decimal, it falls back to 100. Country leaderboards keep using LEADERBOARD_DISPLAY_LIMIT (default 500).
   • Shared helper. A new services/display-limit.ts is used by both leaderboard-service.ts (page/API) and calculate-leaderboard.ts, replacing duplicated limit logic.
   • Title fix. The result title is now "Worldwide" instead of the raw slug.
   • UI. The worldwide page shows its own heading and description (English and Arabic). The worldwide SEO description no longer says "country ranking".
   • Count fix. The "N country leaderboards" count on /leaderboard no longer counts worldwide as a country.
   • Discoverability. A featured "Worldwide leaderboard" card sits at the top of /leaderboard. It is removed from the normal country grid and country search.
   • Docs. .env.example and README.md document the new variable (and the previously undocumented LEADERBOARD_DISPLAY_LIMIT).
   • Tests. 9 new unit tests for the limit logic.

   How I verified it

   • tsc --noEmit: clean
   • ESLint on the touched folders: clean
   • Vitest: all tests pass (140)
   • Manual check in the browser: [fill in after running locally: heading, count, ranking, limit variable]

   How to try it

   1. cp .env.example .env and set GITHUB_TOKEN
   2. pnpm db:up && pnpm redis:up, then pnpm leaderboard:calculate if the database is empty
   3. pnpm run dev, then open /leaderboard and click the Worldwide card
   4. Set WORLDWIDE_LEADERBOARD_DISPLAY_LIMIT=3, restart, and confirm only 3 users show

   Questions for you

   1. Default limit. Is 100 a sensible fallback for worldwide, or would you prefer another number (for example 50 or 500)?
   2. Entry point. Is the featured card at the top of /leaderboard the right placement? Should I also add a link in the site header?
   3. Cache behavior. The cache stores results per slug and slices to the current limit. Lowering the variable takes effect immediately, but raising it may need the cache to refresh first. Is that acceptable, or should the limit be part of the cache key?
   4. Arabic text. I wrote the new Arabic strings myself. Could a native speaker review them?
   5. Scope. Is there anything in the issue I missed, or anything you would like added (for example a worldwide link in the sitemap or a top-N note on the page)?

   Notes

   • No scoring logic or database code was changed.
   • Worldwide is computed from existing user rows, so the background worker needs no extra work for it.

   Thanks for taking a look. I'm happy to adjust anything before opening the PR.

   Screnshots

   
6. O2sa commented on Oct 9, 2026

   

   O2sa

   on Oct 9, 2026

   Last edited by O2sa

   OwnerAuthor

   More actions

   Hi @1-DARK
   I think you already implemented the feature as expected.

   The answer of your questions:

   1. You can set the default limit to 100.
   2. No need for another link in the header, maybe in the future we refactor the whole leaderboard UI.
   3. You can use the same caching behavior, it is ok if the change take a time to appear.
   4. In the localization: just make sure the same keys are exist in the all locales files(ar, en...) and you are fine to go.
   5. It will be good if you add the worldwide link to the sitemap if not added yet. otherwise, everything seems fine..
7. O2sa

   closed this as completedin #231on Oct 10, 2026