Repository navigation
Conversation
The concentrations and the strains are separate callbacks; the concentrations are declared constant over the phase reads and the strains run after them.
…stant-properties-local
petlenz
merged commit Oct 21, 2026
11a5da8
into
feature/constant-properties-producers
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mean_field_strainsplits its concentrations from its strains, so that with constant phases the localisation computes its concentrations once (part 3 of 3, split from #161; stacked on #164).What
docs/mean_field.mddescribes the split.Measured
The same phases as in #164 through
mean_field_strain,linear_stressper phase andmean_field_composite_local_linear, 2000 committed steps,-O2 -DNDEBUG.Tests
MeanFieldLocal.ConstantPhasesAreLocalisedWithConcentrationsComputedOnce: a counting Mori–Tanaka kernel is called once over five committed steps, with stresses and strains equal to plain Mori–Tanaka. It failed before the split.strain_<inclusion>has no callback of its own. Without the writer edges from Constant properties: engine and API #163 it ran afterstiff::stressin some hash orders.test_mean_field_localandtest_short_fibre_compositewere repeated 10× each, all passing.Gates (GCC 14, fetched dependencies): 1182/1182 tests, each also under ASan, 0 warnings. The tree is identical to the last commit of #161, whose 14
docs/materialsreport checks passed.