Repository navigation
HOLD until release: gateway three_ds_mode and Smart mode on the Admin API - #68
next-devin wants to merge 2 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
developer-docs | a37f5d8 | Commit Preview URL Branch Preview URL |
Oct 21 2026, 10:43 AM |
|
|
||
| <Callout type="info"> | ||
| Your store must have a 3DS2-enabled gateway to process 3DS2 transactions. | ||
| Your store must have a 3DS2-enabled gateway to process 3DS2 transactions. A gateway is 3DS2-enabled when its `three_ds_mode` is `smart` or `always`. |
There was a problem hiding this comment.
SUGGESTION: The two sentences in the callout are mashed together without a conjunction. Consider connecting them for readability, e.g. "Your store must have a 3DS2-enabled gateway to process 3DS2 transactions; a gateway is 3DS2-enabled when its three_ds_mode is smart or always."
There was a problem hiding this comment.
Leaving as two sentences: each states one fact, and joining them with a semicolon doesn't read more clearly.
🤖 Addressed by Claude Code
Code Review SummaryStatus: No Issues Found | Recommendation: Merge All five findings from the previous review at
Files Reviewed (4 files)
Notes
Previous Review Summary (commit cf8e77b)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit cf8e77b)Status: 6 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files)
Reviewed by minimax-m3 · Input: 28.8K · Output: 1.9K · Cached: 267.6K |
Hold: merge only after the 3DS Mode release is live in production. Pairs with NextCommerceCo/docs#73.
Changes
three_ds_modeissmartoralways. New Smart mode gateways section: sendpayment_return_urlon every order to asmartgateway, and handle both apayment_complete_url(3DS used) and a directly created order (3DS skipped).PaymentGatewaygainsthree_ds_mode(off/smart/always);enable_3ds2becomes read-only and derived from it. Same change in the gateway webhook schema and examples.Check before merge
The spec edits are hand-written to match the release. If the specs are regenerated from the platform after deploy, prefer the generated output and drop these hunks. The
x-spec-enum-idthe generator adds is not included here.