Repository navigation
Enforce diff index wrapper matching the target environment - #52
Draft
paulochang wants to merge 3 commits into
Draft
paulochang wants to merge 3 commits into
paulochang wants to merge 3 commits into
Conversation
Adobe requires different wrappers for /oak:index/diff.index on Cloud Manager and on the local AEM SDK/RDE in https://experienceleague.adobe.com/en/docs/experience-cloud-kcs/kbarticles/ka-41939 Add option "allowLocalDiffIndexWrapper" to allow the local one This closes Netcentric#51
paulochang
force-pushed
the
diff-index-wrapper-per-environment
branch
from
October 13, 2026 14:35
1e59212 to
d7f43fc
Compare
This reverts commit d7f43fc.
…/RDE Adobe requires different wrappers for /oak:index/diff.index on Cloud Manager and on the local AEM SDK/RDE in https://experienceleague.adobe.com/en/docs/experience-cloud-kcs/kbarticles/ka-41939 Both are already accepted, add a test for the Cloud Manager one and clarify that type="disabled" is only enforced for oak:QueryIndexDefinition
paulochang
marked this pull request as draft
October 13, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adobe requires different wrappers for /oak:index/diff.index on Cloud Manager and on the local AEM SDK/RDE in
https://experienceleague.adobe.com/en/docs/experience-cloud-kcs/kbarticles/ka-41939
Both wrappers are already accepted by the validator: type="disabled" is only enforced for an oak:QueryIndexDefinition (local SDK/RDE wrapper), while the nt:unstructured wrapper used for Cloud Manager is not checked.
Add a test for the Cloud Manager wrapper and clarify this in the README.
The initial approach of enforcing the Cloud Manager wrapper with an option to allow the local one has been reverted.
Relates to #51