Repository navigation
CSTACKEX-207: Automation for snapshot and revert for VM and CS-volume - #122
Open
sathvikaragi wants to merge 1 commit into
Open
sathvikaragi wants to merge 1 commit into
sathvikaragi wants to merge 1 commit into
Conversation
sathvikaragi
requested review from
piyush5netapp,
rajiv-jain-netapp,
sandeeplocharla and
suryag1201
October 14, 2026 10:56
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.84% |
| Branch coverage | 19.00% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Test cases added :
This PR adds steps 07–21 and 23 to the ONTAP VM + volume suites for both NFS3 (nfs3/instance/test_vm_volume_attach.py) and iSCSI (iscsi/instance/test_vm_volume_attach.py). Each suite goes from 10 to 26 tests. The old detach and cleanup steps are renumbered to 22 and 24.
The guest checks use SSH (guest_ssh.py, Paramiko) to write and read marker files on ROOT and DATA. Every snapshot is also checked against a new FlexVol snapshot on ONTAP.
Guest access
07: SSH into the VM and write markers on ROOT and DATA.
Volume snapshots
08 / 09: Snapshot ROOT and DATA on a running VM (VS-01, VS-03).
10: Reverting while the VM is running is rejected (VS-19 for NFS, VS-20 for iSCSI).
11 / 12: Revert ROOT and DATA on a stopped VM; the earlier marker comes back (VS-11 for NFS, VS-12 for iSCSI).
VM snapshots
13 / 14: Take a VM snapshot while the VM is running, then another while it is stopped (VMS-01, VMS-03).
15: Revert to each of those two snapshots in turn (VMS-09).
16: Two snapshot requests for the same VM at the same time (VMS-53).
Two VMs on one pool
17: Deploy a second VM with its ROOT disk on the same ONTAP pool.
18: Reverting one VM leaves the other VM's data alone (VS-28).
19: VM snapshots of both VMs at the same time (VMS-54 for NFS, VMS-55 for iSCSI).
20 / 21: A snapshot on one VM while the other VM reverts, first with volume snapshots and then with VM snapshots.
23: Expunge a VM that still has a VM snapshot; its FlexVol snapshot is removed (VMS-38).
Supporting changes: guest_ssh.py, a paramiko>=3.4,<4 pin in setup_env.sh, and updated README.md and TEST_CASES.md. The catalog now lists 106 tests in total.
Result: Both suites passed 26/26 on the lab.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?