CSTACKEX-261: enabling cloudstack volume resize (GROW) for iscsi and nfs - #100
Open
sathvikaragi wants to merge 1 commit into
Open
sathvikaragi wants to merge 1 commit into
sathvikaragi wants to merge 1 commit into
Conversation
sathvikaragi
requested review from
piyush5netapp,
rajiv-jain-netapp,
sandeeplocharla and
suryag1201
as code owners
September 15, 2026 05:22
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.71% |
| Branch coverage | 18.85% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
| } | ||
|
|
||
| public Volume getStorageVolume(String uuid) { | ||
| logger.info("getStorageVolume: Fetching ONTAP volume by UUID: {}", uuid); |
There was a problem hiding this comment.
Better to have null check for UUID field
suryag1201
reviewed
Sep 17, 2026
| CloudStackVolume cloudStackVolume = new CloudStackVolume(); | ||
| cloudStackVolume.setVolumeInfo(volumeInfo); | ||
|
|
||
| if (ProtocolType.ISCSI.name().equals(details.get(OntapStorageConstants.PROTOCOL))) { |
| public void resize(DataObject data, AsyncCompletionCallback<CreateCmdResult> callback) { | ||
| CreateCmdResult result = null; | ||
| try { | ||
| VolumeInfo volumeInfo = (VolumeInfo) data; |
There was a problem hiding this comment.
Have a data type check here before type casting it to a specific type.
| CreateCmdResult result = null; | ||
| try { | ||
| VolumeInfo volumeInfo = (VolumeInfo) data; | ||
| ResizeVolumePayload payload = (ResizeVolumePayload) volumeInfo.getpayload(); |
| volumeVO.setSize(payload.newSize); | ||
| volumeDao.update(volumeVO.getId(), volumeVO); | ||
|
|
||
| result = new CreateCmdResult(null, new Answer(null, true, null)); |
There was a problem hiding this comment.
dont we need to pass path back as part of CreateCmdResult ? Also I think we should pass the exact type of Command as part of Answer
There was a problem hiding this comment.
it is getting set in finally block below
| Map<String, String> poolDetails = storagePoolDetailsDao.listDetailsKeyPairs(storagePool.getId()); | ||
| String flexVolUuid = poolDetails != null ? poolDetails.get(OntapStorageConstants.VOLUME_UUID) : null; | ||
|
|
||
| if (StringUtils.isBlank(flexVolUuid)) { |
There was a problem hiding this comment.
lets discuss on this today-> Lets say we somehow miss to update the details map for flexvol uuid, should not we instead of no/op , have a secondary code (making live ontap call to by storage pool name) ?
| volume.getSize(), sizeInBytes, false, null); | ||
| // instanceName is set by VolumeApiServiceImpl.orchestrateResizeVolume() before calling the | ||
| // driver — it is the VM instance name when attached, or "none" when the volume is detached. | ||
| ResizeVolumePayload resizePayload = volumeObject.getpayload() instanceof ResizeVolumePayload |
There was a problem hiding this comment.
isn't this already been taken care at ontap driver class ?
| volumeVO.setSize(payload.newSize); | ||
| volumeDao.update(volumeVO.getId(), volumeVO); | ||
|
|
||
| result = new CreateCmdResult(null, new Answer(null, true, null)); |
There was a problem hiding this comment.
it is getting set in finally block below
| CloudStackVolume cloudStackVolume = new CloudStackVolume(); | ||
| cloudStackVolume.setVolumeInfo(volumeInfo); | ||
|
|
||
| if (ProtocolType.ISCSI.name().equals(details.get(OntapStorageConstants.PROTOCOL))) { |
There was a problem hiding this comment.
can this protocol specific code go to strategy based impl?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cloudstack volume resize supports grow for both NFS and Iscsi which on ontap leads to increase in size for a LUN in case of iscsi and file in case of NFS.Also consists of UT's for the changes and implementation for getusedbytes which is called in this flow to check if storagepool has enough space.
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?