Skip to content

Fixed an issue causing erroneous error messages. #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcantrel merged 2 commits into from
Oct 8, 2026
Merged

Fixed an issue causing erroneous error messages. #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8776b79
Fixed an issue causing erroneous error messages.
kcantrel Oct 8, 2026
d133f44
Merge branch 'main' into update_terraform_checks
kcantrel Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_filesystems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ get_filesystems () {
local region=$1
local pattern=$2

mkdir $tmpdir/$region
mkdir $tmpdir/$region > /dev/null 2>&1
local tmpdir=$tmpdir/$region

tmpout=$(mktemp -p $tmpdir list_fss-output.XXX)
Expand Down Expand Up @@ -381,10 +381,11 @@ done
while [ ${#pids[@]} -gt 0 ]; do
wait -n -p pid "${!pids[@]}"
if [ $? -ne 127 ]; then
cat $tmpdir/${pids[$pid]}.out
cat $tmpdir/${pids[$pid]}.out 2> /dev/null
unset pids[$pid]
else
echo "Error, waiting for an non-existent process. This should never happen." 1>&2
exit 1
# If this happens none of the PIDs are still running so somehow we missed one with the
# wait command. Regardless as to why or how, there is no reason to keep waiting.
exit 0
fi
done
8 changes: 4 additions & 4 deletions Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_svms
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ start_watchdog () {
get_svms () {
region=$1

mkdir $tmpdir/$region
mkdir $tmpdir/$region > /dev/null 2>&1
local tmpdir=$tmpdir/$region
tmpout=$tmpdir/output
tmpout2=$tmpdir/output2
Expand Down Expand Up @@ -200,10 +200,10 @@ done
while [ ${#pids[@]} -gt 0 ]; do
wait -n -p pid "${!pids[@]}"
if [ $? -ne 127 ]; then
cat $tmpdir/${pids[$pid]}.out
cat $tmpdir/${pids[$pid]}.out 2> /dev/null
unset pids[$pid]
else
echo "Error, waiting for an non-existent process. This should never happen." 1>&2
exit 1
# If the wait command returns 127, then all processes are no longer running so exit.
exit 0
fi
done
8 changes: 4 additions & 4 deletions Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_volumes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ start_watchdog () {
get_volumes () {
local region=$1

mkdir $tmpdir/$region
mkdir $tmpdir/$region > /dev/null 2>&1
local tmpdir=$tmpdir/$region

volumeList=$tmpdir/list_aws_vol-out
Expand Down Expand Up @@ -298,10 +298,10 @@ done
while [ ${#pids[@]} -gt 0 ]; do
wait -n -p pid "${!pids[@]}"
if [ $? -ne 127 ]; then
cat $tmpdir/${pids[$pid]}.out
cat $tmpdir/${pids[$pid]}.out 2> /dev/null
unset pids[$pid]
else
echo "Error, waiting for an non-existent process. This should never happen." 1>&2
exit 1
# If wait returns 127, it means there are no more child processes to wait for.
exit 0
fi
done
Loading