Skip to content

chore(ci): disable pr release comments - #435

Merged
coryrylan merged 1 commit into
mainfrom
topic-release-script
Oct 21, 2026
Merged

coryrylan merged 1 commit into
mainfrom
topic-release-script

Conversation

@coryrylan

@coryrylan coryrylan commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • GitHub release workflows no longer post automatic success comments.

Signed-off-by: Cory Rylan <crylan@nvidia.com>
@coryrylan coryrylan self-assigned this Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/elements/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Enterprise
  • Run ID: ca4ec487-1f5c-4529-abe8-dc6298c9255e
📥 Commits

Reviewing files that changed from the base of the PR and between d9cd456 and 1422693.

📒 Files selected for processing: 1
  • release.config.js

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The GitHub release plugin no longer posts a success comment after a release. Its configuration now sets successComment to false.

Changes: Release comment behavior

Layer / File(s) Summary
Disable release success comments
release.config.js
The GitHub plugin disables success comments instead of using a template with the released version and changelog link.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: johnyanarella

Merge Risk: ⚪ Minimal · up to 14226

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: disabling pull request release comments in CI.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The plan checks success comments after a package release. It also checks published GitHub Releases and the release job. An issue escalates when the release job fails or published GitHub Releases stop.

Not monitored: no services

Mention @change-monitor in a comment to update the plan.

Plan

What changed

GitHub no longer posts a success comment on issues after a package release. The GitHub plugin still creates GitHub Releases. This file is shared semantic-release config. Catalog search for release and elements found no service slug. The change is live on the next release job after merge to main.

Risk

A bad GitHub plugin option can fail the release job after npm publish. GitHub Releases would stop. Slack release notices would stop. npm packages may already be public. Comments would stay off, which is intended.

Intended effect

The new behavior is that success comments stop. No queryable count of those comments exists. This change adds no production metric. Absent looks like comments still appearing after the next successful release. The executor needs GitHub issue comments on released pull requests to fill this axis.

Regression watch

This change can fail the GitHub plugin after npm publish. The first failure users see is a failed release job on main. Published GitHub Releases and Slack release notices would then stop. No measured baseline exists for these watches. The executor needs the release job result and GitHub Release publishes to fill this axis.

Not observable

GitHub success comments that say this issue has been resolved in version are not queryable. The Datadog connector is not available this session. It needs re-authorization or repair. GitHub Actions release job failures are not queryable. GitHub Release publish count and Slack notify job results are not queryable. npm publish success on the exec plugin path is not queryable. The pre-ship rate for GitHub plugin runs on main is missing.

Get Slack DMs about this change: cursor.com/automations/rollouts

@coryrylan
coryrylan enabled auto-merge (rebase) October 21, 2026 16:32
@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/vitest

main b4df8f3 topic-release-script 1422693 +/-
99% 99% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@coryrylan
coryrylan merged commit 5670642 into main Oct 21, 2026
17 checks passed
@coryrylan
coryrylan deleted the topic-release-script branch October 21, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants